Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goldmark to v1.4.11 #19201

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Bump goldmark to v1.4.11 #19201

merged 2 commits into from
Mar 24, 2022

Conversation

xoxys
Copy link
Contributor

@xoxys xoxys commented Mar 24, 2022

Unfortunately goldmark 1.4.8 contains a bug whereby html comments on checklist elements are mistakenly rendered. This has been fixed upstream with goldmark 1.4.11.

Regression introduced in: #19127
Upstream issue: yuin/goldmark#285

Fix: #19195

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 24, 2022
@noerw noerw added this to the 1.17.0 milestone Mar 24, 2022
@xoxys
Copy link
Contributor Author

xoxys commented Mar 24, 2022

While the issue was added to 1.16.6 Milestone, the PR was added to 1.17.0 is that intended?

@noerw
Copy link
Member

noerw commented Mar 24, 2022

@xoxys yes, your PR targets the main branch (1.17-dev), but the issue is also in 1.16.5, so we'll need to backport that. Would you mind to do that? (i.e. open another PR targeting the release/v1.16 branch)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2022
@xoxys
Copy link
Contributor Author

xoxys commented Mar 24, 2022

Ah got it, thanks :) Sure I can do it.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@techknowlogick techknowlogick merged commit 909804b into go-gitea:main Mar 24, 2022
techknowlogick pushed a commit that referenced this pull request Mar 24, 2022
* Bump goldmark to v1.4.11

* fix go.sum

Signed-off-by: Andrew Thornton <art27@cantab.net>

* add testcase

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Andrew Thornton <art27@cantab.net>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 25, 2022
* giteaofficial/main:
  Add pprof labels in processes and for lifecycles (go-gitea#19202)
  [skip ci] Updated translations via Crowdin
  Bump goldmark to v1.4.11 (go-gitea#19201)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Bump goldmark to v1.4.11

* add testcase

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 29, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Html comments are shown in PR and issue descriptions
6 participants