Add note to GPG key response if user has no keys #18961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Mar 1, 2022
GiteaBot
added
the
lgtm/need 2
Gusted
approved these changes
Mar 1, 2022
GiteaBot
added
lgtm/done
Yes.
So far I can see, it's only used in the web part. |
Yes, but the response looks like something a tool uses as input which could be confused by html error page. |
Well, I hope that tools can detect a simple 404 statuscode 😅 . |
zeripath
approved these changes
Mar 1, 2022
zeripath
suggested changes
Mar 1, 2022
|
This response should be: |
KN4CK3R
added
type/enhancement
Gusted
approved these changes
Mar 2, 2022
|
CI errors are related |
|
Should this be backported? |
zeripath
approved these changes
Mar 2, 2022
|
This is very minor - a backport is reasonable but equally not sending one is also reasonable. |
KN4CK3R
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 3, 2022
* giteaofficial/main: Don't clean up hardcoded `tmp` (go-gitea#18983) git backend ignore replace objects (go-gitea#18979) Improve the deletion of issue (go-gitea#18945) Add note to GPG key response if user has no keys (go-gitea#18961) adds restore docs for docker based instances (go-gitea#18844) Refactor admin user filter query parameters (go-gitea#18965)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Mar 3, 2022
* main: ignore missing comment for user notifications (go-gitea#18954) allow overwrite artifacts for github releases (go-gitea#18987) fix & refactor (go-gitea#18973) Don't clean up hardcoded `tmp` (go-gitea#18983) git backend ignore replace objects (go-gitea#18979) Improve the deletion of issue (go-gitea#18945) Add note to GPG key response if user has no keys (go-gitea#18961) adds restore docs for docker based instances (go-gitea#18844) Refactor admin user filter query parameters (go-gitea#18965)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Prevent invalid key response. * Display note instead of 404 response. * Fixed test. Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the invalid reponse if there are no keys:Additional questions:ShouldShowSSHKeysdo the same?Is this an "api" endpoint and the response should be just the plain 404 response code instead of the html page? If yes we need to add an addition route for/orgs/<org>.gpgto get the same behaviour there too.Adds a note if user has no keys.