Delete related notifications on issue deletion too #18953
Conversation
GiteaBot
added
lgtm/need 2
fnetX
force-pushed
the
fnetx-code-consistency
branch
from
05bc0e6
to
465a42f
Compare
|
Hey, I dropped the Action removal (will do this in a separate PR). The only thing left I wanted to do in this PR is to remove the notifications for removed issues. Please note this is actually a bug I'd either backport that or the whole PR). I thought with #18954 this wouldn't be too weird, but we are facing the bug on Codeberg.
I wonder if I should attempt writing a migration to remove eventual left over notifications. But I'm not sure how migrations can be backported (if at all), because they have a linear counter. If a migration is backported, it probably either shares an id with another important upcoming migration, or increments the counter so that all migrations until then are skipped. Or do I misunderstand the system? Also note that notifications are also not removed for deleted comments already. I noticed this in the past already, it's a bug on its own (and I'm not going to address this, because I currently can't think of a solution to see if a still needs a notification for the issue (previous post) or has already read the notification. Probably with the issue read state?). |
GiteaBot
added
lgtm/need 1
6543
changed the title
@fnetX the |
|
But most people don't run it, do they? Anyway, I'm fine with not bothering. After all, since it's not live for long and not even released yet, it's unlikely many people have clicked the button. |
|
well yes - that's why a doctor task would be the best way to do so ... - we can merge this fix first and work in that afterwards |
|
Oh, by the way, you can remove the backport label again. It's not in 1.16. I was confused about that earlier, too, because it's deployed on Codeberg. (So I'll backport anyway, but not for Gitea). |
GiteaBot
added
lgtm/done
* giteaoffical/main: remove not needed (go-gitea#19128) Add warning to set SENDMAIL_ARGS to -- (go-gitea#19102) Do not send activation email if manual confirm is set (go-gitea#19119) Update tool dependencies (go-gitea#19120) Delete related notifications on issue deletion too (go-gitea#18953) nit fix (go-gitea#19116) Store the foreign ID of issues during migration (go-gitea#18446) Remove italics for `due_date_not_set` (go-gitea#19113)
* use .Decr for issue comment counting * Remove notification on issue removal
* use .Decr for issue comment counting * Remove notification on issue removal
as title