Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Stats Indexer reporting error if repo dir missing #18870

Conversation

zeripath
Copy link
Contributor

Repositories missing their directory should not report an error from the stats
indexer.

Close #18847

Signed-off-by: Andrew Thornton art27@cantab.net

Repositories missing their directory should not report an error from the stats
indexer.

Close go-gitea#18847

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Feb 23, 2022
@zeripath zeripath added this to the 1.17.0 milestone Feb 23, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2022
@zeripath
Copy link
Contributor Author

Could be backported to 1.16 - but should not hold up releases

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18870 (9c1fb86) into main (4d93984) will decrease coverage by 0.06%.
The diff coverage is 45.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18870      +/-   ##
==========================================
- Coverage   46.64%   46.58%   -0.07%     
==========================================
  Files         846      853       +7     
  Lines      121331   122514    +1183     
==========================================
+ Hits        56595    57068     +473     
- Misses      57859    58554     +695     
- Partials     6877     6892      +15     
Impacted Files Coverage Δ
cmd/admin_auth_ldap.go 79.59% <ø> (ø)
models/auth/webauthn.go 43.11% <ø> (ø)
models/org.go 73.88% <0.00%> (+0.21%) ⬆️
modules/git/pipeline/lfs_nogogit.go 0.00% <0.00%> (ø)
modules/git/pipeline/namerev.go 0.00% <0.00%> (ø)
modules/graceful/manager.go 22.16% <0.00%> (-0.13%) ⬇️
modules/graceful/manager_unix.go 38.88% <0.00%> (-0.95%) ⬇️
modules/queue/manager.go 39.59% <0.00%> (-0.83%) ⬇️
modules/queue/queue_bytefifo.go 46.90% <0.00%> (-2.54%) ⬇️
modules/structs/repo.go 76.92% <ø> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2f11e...9c1fb86. Read the comment docs.

@techknowlogick techknowlogick merged commit f1c6cf7 into go-gitea:main Feb 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 25, 2022
* giteaofficial/main:
  Prevent Stats Indexer reporting error if repo dir missing (go-gitea#18870)
  [skip ci] Updated translations via Crowdin
  Fix update user (go-gitea#18878)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…8870)

Repositories missing their directory should not report an error from the stats
indexer.

Close go-gitea#18847

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@zeripath zeripath deleted the do-not-report-error-for-missing-repo-in-stats branch December 29, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on dexer/stats/queue.go
8 participants