Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unnecessary mirroring elements #18527

Merged
merged 7 commits into from
Jun 4, 2022
Merged

Conversation

pboguslawski
Copy link
Contributor

This mod fixes disabling unnecessary mirroring elements (UI items and cron job).

Related: #16957
Related: #13084
Author-Change-Id: IB#1105104

This mod fixes disabling unnecessary mirroring elements.

Related: go-gitea#16957
Related: go-gitea#13084
Author-Change-Id: IB#1105104
@pboguslawski
Copy link
Contributor Author

This is updated version of #13084 adjusted to current main.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2022
@techknowlogick techknowlogick added this to the 1.17.0 milestone Feb 2, 2022
pboguslawski and others added 2 commits February 11, 2022 11:33
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: silverwind <me@silverwind.io>
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 16, 2022
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 25, 2022
@stale stale bot removed the issue/stale label May 25, 2022
@lunny
Copy link
Member

lunny commented May 25, 2022

I think there is only one block here.

@pboguslawski
Copy link
Contributor Author

I think there is only one block here.

Please clarify if you think something more should be done in this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2022
@lunny
Copy link
Member

lunny commented Jun 4, 2022

Please update the branch

@pboguslawski
Copy link
Contributor Author

Done.

@lunny lunny merged commit 14d96ff into go-gitea:main Jun 4, 2022
@pboguslawski pboguslawski deleted the main-IB#1105104 branch June 4, 2022 11:49
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 4, 2022
* giteaofficial/main:
  Add API to serve blob or LFS file content (go-gitea#19689)
  Disable unnecessary mirroring elements (go-gitea#18527)
  [skip ci] Updated translations via Crowdin
  Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (go-gitea#19861)
  Set Setpgid on child git processes (go-gitea#19865)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Disable unnecessary mirroring elements

This mod fixes disabling unnecessary mirroring elements.

Related: go-gitea#16957
Related: go-gitea#13084
Author-Change-Id: IB#1105104

* Checkbox rendering disabled instead of hiding it

Fixes: 02b4505
Related: go-gitea#18527 (review)
Author-Change-Id: IB#1105104

* Update custom/conf/app.example.ini

Co-authored-by: silverwind <me@silverwind.io>

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

Co-authored-by: silverwind <me@silverwind.io>

* Mirror filter removed only when whole mirroring feature is disabled

Fixes: 02b4505
Related: go-gitea#18527 (comment)
Author-Change-Id: IB#1105104

Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants