DISABLE_2FA parameter for disabling 2FA added #18481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitea does not use 2FA when reverse proxy auth is enabled. 2FA is hardcoded and cannot be disabled (i.e. when stronger authentication scheme is implemented on reverse proxy). Leaving unused elements like 2FA in UI should be avoided to make UI clean and to avoid unnecessarry maintanance (questions/problems from users). This mod introduces new `DISABLE_2FA` parameter in app.ini section `[security]`. When disabled (default when parameter is not present) gitea behaves as without this mod (2FA is available). When enabled, 2FA feature and its UI elements are not avaiable. This mod also hides those areas on Settings/Security page that are disabled in config and hides menu link to Security page if all its areas are disabled in config. Related: go-gitea#13129 Author-Change-Id: IB#1115243
|
Should Enforce 2FA (#16880) be considered together .... |
GiteaBot
added
the
lgtm/need 2
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
lunny
added
the
issue/confirmed
|
I think we need a global design for Gitea's auth system, instead of patching too many "disable" options. Such design would conflict with Enforce 2FA, which is required by a lot of people. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitea does not use 2FA when reverse proxy auth is enabled. 2FA is hardcoded
and cannot be disabled (i.e. when stronger authentication scheme is
implemented on reverse proxy). Leaving unused elements like 2FA in UI should
be avoided to make UI clean and to avoid unnecessarry maintanance
(questions/problems from users).
This mod introduces new
DISABLE_2FAparameter in app.ini section[security]. When disabled (default when parameter is not present) giteabehaves as without this mod (2FA is available). When enabled, 2FA feature
and its UI elements are not avaiable.
This mod also hides those areas on Settings/Security page that are
disabled in config and hides menu link to Security page if all its areas
are disabled in config.
Related: #13129
Author-Change-Id: IB#1115243