Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #18436

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Fix typo #18436

merged 3 commits into from
Jan 28, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 28, 2022

As title

Fix typo
7b36ab7 
As title
@Gusted Gusted added this to the 1.17.0 milestone Jan 28, 2022
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 28, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Jan 28, 2022

Introduced in #15066

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18436 (7b36ab7) into main (8038610) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18436      +/-   ##
==========================================
- Coverage   46.00%   45.99%   -0.02%     
==========================================
  Files         842      842              
  Lines       93160    93160              
==========================================
- Hits        42858    42847      -11     
- Misses      43503    43513      +10     
- Partials     6799     6800       +1
Impacted Files Coverage Δ
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/queue/workerpool.go 54.37% <0.00%> (-2.50%) ⬇️
modules/process/manager.go 81.39% <0.00%> (-1.56%) ⬇️
modules/queue/queue_channel.go 82.60% <0.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8038610...7b36ab7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2022
@lunny
Copy link
Member

lunny commented Jan 28, 2022

make L-G-T-M work.

@lunny lunny merged commit 7b04c97 into go-gitea:main Jan 28, 2022
@Gusted Gusted deleted the fix-typo branch January 28, 2022 14:23
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @lafriks
Fix typo (go-gitea#18436)
2804856 
As title

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @codecov-commenter @lunny @techknowlogick @lafriks @GiteaBot