Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deprecation error for v1.17.0 #18341

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 20, 2022

Per title

Introduced in #16957 by @6543

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 20, 2022
@wxiaoguang
Copy link
Contributor

Do we really need these two logs? I prefer to only output one error log.

@Gusted
Copy link
Contributor Author

Gusted commented Jan 20, 2022

Do we really need these two logs? I prefer to only output one error log.

Not sure, both messages are important. But I think it can be merged into 1 bigger message.

@codecov-commenter
Copy link

Codecov Report

Merging #18341 (4b92fb2) into main (5bf8d54) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 4b92fb2 differs from pull request most recent head e6447be. Consider uploading reports for the commit e6447be to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18341      +/-   ##
==========================================
+ Coverage   46.10%   46.11%   +0.01%     
==========================================
  Files         837      837              
  Lines       92331    92332       +1     
==========================================
+ Hits        42566    42579      +13     
+ Misses      43004    42993      -11     
+ Partials     6761     6760       -1     
Impacted Files Coverage Δ
modules/setting/mirror.go 5.26% <0.00%> (-0.30%) ⬇️
modules/notification/mail/mail.go 42.10% <0.00%> (-2.64%) ⬇️
modules/convert/repository.go 91.17% <0.00%> (-1.48%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/notification.go 66.59% <0.00%> (-0.87%) ⬇️
models/issue_comment.go 54.86% <0.00%> (+0.28%) ⬆️
services/pull/pull.go 42.79% <0.00%> (+0.40%) ⬆️
routers/api/v1/repo/pull.go 28.85% <0.00%> (+0.50%) ⬆️
modules/process/manager.go 82.94% <0.00%> (+1.55%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf8d54...e6447be. Read the comment docs.

@zeripath
Copy link
Contributor

we got anymore of these?

@Gusted
Copy link
Contributor Author

Gusted commented Jan 20, 2022

Not that I can find, or they are worded differently.

@zeripath
Copy link
Contributor

yup we got a few... let me add some code.

modules/setting/mirror.go Outdated Show resolved Hide resolved
@zeripath

This comment has been minimized.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.17.0 milestone Jan 20, 2022
@zeripath zeripath added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 20, 2022
Gusted and others added 2 commits January 20, 2022 17:12
Do some more deprecations and add common comment // FIXME: DEPRECATION
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2022
@zeripath zeripath mentioned this pull request Jan 20, 2022
@6543 6543 merged commit 1d98d20 into go-gitea:main Jan 20, 2022
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 21, 2022
* giteaoffical/main:
  [skip ci] Updated translations via Crowdin
  Refactor jwt.StandardClaims to RegisteredClaims (go-gitea#18344)
  format with gofumpt (go-gitea#18184)
  Enable deprecation error for v1.17.0 (go-gitea#18341)
  Use correct translation key for errors (go-gitea#18342)
  Refactor Router Logger (go-gitea#17308)
  Updated Chroma to v0.10.0 (go-gitea#18270)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Co-authored-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants