Remove accidental debugging in blob_excerpt.tmpl #18287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately it appears that a small bit of debugging code was left in blob_excerpt.tmpl This breaks diff expansion causing go-gitea#18281. Fix go-gitea#18281 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
skip-changelog
Gusted
approved these changes
Jan 15, 2022
GiteaBot
added
the
lgtm/need 1
|
How about line 71: Is it ( |
Signed-off-by: Andrew Thornton <art27@cantab.net>
…into fix-18281-fix-expanding-diff
|
yup that also needs fixing.. |
wxiaoguang
approved these changes
Jan 16, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #18287 +/- ##
=======================================
Coverage 45.73% 45.73%
=======================================
Files 831 831
Lines 92172 92172
=======================================
+ Hits 42154 42159 +5
+ Misses 43260 43257 -3
+ Partials 6758 6756 -2
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 17, 2022
* 'main' of https://github.com/go-gitea/gitea: show pull link for agit pull request also (go-gitea#18235) [skip ci] Updated translations via Crowdin Add some .ignore entries (go-gitea#18296) Remove unneeded debug messages to stdout. (go-gitea#18298) Handle missing default branch better in owner/repo/branches page (go-gitea#18290) Revert "Prevent possible XSS when using jQuery (go-gitea#18289)" (go-gitea#18293) not show double error response in git hook (go-gitea#18292) Remove accidental debugging in blob_excerpt.tmpl (go-gitea#18287) Prevent possible XSS when using jQuery (go-gitea#18289) Return nicer error if trying to pull from non-existent user (go-gitea#18288) [skip ci] Updated translations via Crowdin docs: mention client_max_body_size affects LFS (go-gitea#18291) Add lockfile-check (go-gitea#18285) Webauthn nits (go-gitea#18284)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Remove accidental debugging in blob_excerpt.tmpl Unfortunately it appears that a small bit of debugging code was left in blob_excerpt.tmpl This breaks diff expansion causing go-gitea#18281. Fix go-gitea#18281 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it appears that a small bit of debugging code was left in blob_excerpt.tmpl
This breaks diff expansion causing #18281.
Fix #18281
Signed-off-by: Andrew Thornton art27@cantab.net