Add config options to hide issue events #17414

qwerty287 · 2021-10-23T17:13:38Z

Adds config options to the user settings to hide most issue events (changed labels, milestones, projects...) on the issue detail page.

Closes #11418

Adds a config option `HIDE_ISSUE_EVENTS` to hide most issue events (changed labels, milestones, projects...) on the issue detail page. If this is true, only the following events (comment types) are shown: * plain comments * closed/reopned/merged * reviews

custom/conf/app.example.ini

wxiaoguang · 2021-10-24T03:43:26Z

I think we should group these events into one line, instead of hiding them.

GitHub does a good example.

==

Update: I just found that the grouping feature had been implemented.

In my opinion, we should not use a global setting option to hide some events, it brings divergences in future, some one wants to hide this, some one else wants to hide others.

qwerty287 · 2021-10-24T05:49:14Z

@wxiaoguang if you take a look at the linked issue, you'll find this comment:

I mean when you create serval labels for one issue, we could just display one label comment.

done in #13304 🎉 - but I'll leave it open since this propose "hide all event comments"

lafriks · 2021-10-24T13:40:18Z

Why not instead of adding additional app setting just make it as user preference? (There was already PR to move user settings to new table so it should not be too hard to add new setting)

qwerty287 · 2021-10-24T13:49:10Z

@lafriks this PR is AFAIK not merged yet, so this would be blocked until then and this would be probably incompatible to the list suggested by @lunny above (which I implemented already)

lafriks · 2021-10-24T14:55:47Z

I don't see why it could not be saved as json un user settings and implemented as checkboxes.

My point is we already have way too many settings in app.ini and we should avoid adding more if that's possible imho

qwerty287 · 2021-10-24T15:45:46Z

Yes in general I agreed (also because not every user on an instance must like it if it's disabled) but I wasn't sure about the implementation, but I didn't thought about the way using a JSON, which is fine. So this is probably blocked by #16834

qwerty287 · 2021-10-24T15:48:45Z

The only thing I'd like to know is to which page in the settings I'd add it, since it doesn't really fit one of the current pages

noerw · 2021-10-24T21:12:04Z

imho the user settings page is missing an "appearance" tab. then we can move theme, language from the other (unrelated) tabs as well.

qwerty287 · 2021-10-25T15:15:10Z

I added a appearance tab in a separate branch, https://github.com/qwerty287/gitea/tree/appearance-prefs, and could open a PR for this if you like it :)

templates/repo/issue/view_content/comments.tmpl

lafriks · 2021-10-25T16:50:45Z

I added a appearance tab in a separate branch, https://github.com/qwerty287/gitea/tree/appearance-prefs, and could open a PR for this if you like it :)

Yes, please, do so

qwerty287 · 2021-10-26T15:06:45Z

A maintainer might add the status/blocked label?

Gusted

Just a few things, but overall it looks good to me.

models/user/setting_keys.go

routers/web/repo/issue.go

services/forms/user_form_hidden_comments.go

Co-authored-by: Gusted <williamzijl7@hotmail.com>

qwerty287 · 2022-01-20T17:06:35Z

Would anybody mind merging this?

qwerty287 · 2022-01-20T17:13:51Z

Of course only after I resolved conflicts...

qwerty287 · 2022-01-21T14:28:30Z

Merged and resolved conflicts, ready for merge.

models/user/setting.go

* giteaoffical/main: [skip ci] Updated translations via Crowdin Add config options to hide issue events (go-gitea#17414) Add js vendor directory to .gitattributes (go-gitea#18350)

* Add config option to hide issue events Adds a config option `HIDE_ISSUE_EVENTS` to hide most issue events (changed labels, milestones, projects...) on the issue detail page. If this is true, only the following events (comment types) are shown: * plain comments * closed/reopned/merged * reviews * Make configurable using a list * Add docs * Add missing newline * Fix merge issues * Allow changes per user settings * Fix lint * Rm old docs * Apply suggestions from code review * Use bitsets * Rm comment * fmt * Fix lint * Use variable/constant to provide key * fmt * fix lint * refactor * Add a prefix for user setting key * Add license comment * Add license comment * Update services/forms/user_form_hidden_comments.go Co-authored-by: Gusted <williamzijl7@hotmail.com> * check len == 0 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: 6543 <6543@obermui.de>

This comment has been minimized.

Sign in to view

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2021

lunny reviewed Oct 24, 2021

View reviewed changes

custom/conf/app.example.ini Outdated Show resolved Hide resolved

qwerty287 added 2 commits October 24, 2021 15:58

Make configurable using a list

b2ac2a5

Add docs

e499016

6543 reviewed Oct 25, 2021

View reviewed changes

templates/repo/issue/view_content/comments.tmpl Outdated Show resolved Hide resolved

qwerty287 and others added 2 commits October 25, 2021 17:48

Add missing newline

d14beda

Merge branch 'main' into hide-issue-events

3d8abdc

qwerty287 mentioned this pull request Oct 25, 2021

Add appearance section in settings #17433

Merged

Merge branch 'main' into hide-issue-events

7e94f54

wxiaoguang added pr/wip This PR is not ready for review status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Oct 26, 2021

qwerty287 and others added 6 commits October 28, 2021 15:14

Merge branch 'main' into hide-issue-events

141611e

Merge branch 'main' into hide-issue-events

c3f40ae

Merge branch 'main' into hide-issue-events

d17579d

Merge branch 'main' into hide-issue-events

26270f1

Fix merge issues

7eabacf

Merge branch 'main' into hide-issue-events

20e9fc9

wxiaoguang approved these changes Dec 27, 2021

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2021

Merge branch 'main' into hide-issue-events

8723518

qwerty287 requested a review from Gusted January 7, 2022 16:15

Gusted reviewed Jan 7, 2022

View reviewed changes

models/user/setting_keys.go Show resolved Hide resolved

routers/web/repo/issue.go Show resolved Hide resolved

services/forms/user_form_hidden_comments.go Outdated Show resolved Hide resolved

zeripath and others added 2 commits January 7, 2022 21:48

Merge branch 'main' into hide-issue-events

e2de406

Update services/forms/user_form_hidden_comments.go

e6b31ad

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Gusted approved these changes Jan 8, 2022

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2022

Merge branch 'main' into hide-issue-events

b8c2785

wxiaoguang mentioned this pull request Jan 8, 2022

[Feature Request] Hide issuecomment events #11418

Closed

Merge branch 'main' into hide-issue-events

24a927a

wxiaoguang added this to the 1.17.0 milestone Jan 16, 2022

Gusted mentioned this pull request Jan 21, 2022

Add user settings key/value DB table #16834

Merged

Merge branch 'main' into hide-issue-events

eb8caac

Merge branch 'main' into hide-issue-events

dcd7041

6543 reviewed Jan 21, 2022

View reviewed changes

models/user/setting.go Show resolved Hide resolved

check len == 0

c3933ba

6543 approved these changes Jan 21, 2022

View reviewed changes

6543 merged commit 1f40933 into go-gitea:main Jan 21, 2022

qwerty287 deleted the hide-issue-events branch January 24, 2022 14:50

Gusted mentioned this pull request Mar 30, 2022

User keypairs and HTTP signatures for ActivityPub federation using go-ap #19133

Merged

1 task

go-gitea locked and limited conversation to collaborators Apr 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add config options to hide issue events #17414

Add config options to hide issue events #17414

qwerty287 commented Oct 23, 2021 •

edited

Loading

This comment has been minimized.

wxiaoguang commented Oct 24, 2021 •

edited

Loading

qwerty287 commented Oct 24, 2021

lafriks commented Oct 24, 2021

qwerty287 commented Oct 24, 2021 •

edited

Loading

lafriks commented Oct 24, 2021

qwerty287 commented Oct 24, 2021

qwerty287 commented Oct 24, 2021

noerw commented Oct 24, 2021 •

edited

Loading

qwerty287 commented Oct 25, 2021

lafriks commented Oct 25, 2021

qwerty287 commented Oct 26, 2021

Gusted left a comment

qwerty287 commented Jan 20, 2022

qwerty287 commented Jan 20, 2022

qwerty287 commented Jan 21, 2022

Add config options to hide issue events #17414

Add config options to hide issue events #17414

Conversation

qwerty287 commented Oct 23, 2021 • edited Loading

This comment has been minimized.

wxiaoguang commented Oct 24, 2021 • edited Loading

qwerty287 commented Oct 24, 2021

lafriks commented Oct 24, 2021

qwerty287 commented Oct 24, 2021 • edited Loading

lafriks commented Oct 24, 2021

qwerty287 commented Oct 24, 2021

qwerty287 commented Oct 24, 2021

noerw commented Oct 24, 2021 • edited Loading

qwerty287 commented Oct 25, 2021

lafriks commented Oct 25, 2021

qwerty287 commented Oct 26, 2021

Gusted left a comment

Choose a reason for hiding this comment

qwerty287 commented Jan 20, 2022

qwerty287 commented Jan 20, 2022

qwerty287 commented Jan 21, 2022

qwerty287 commented Oct 23, 2021 •

edited

Loading

wxiaoguang commented Oct 24, 2021 •

edited

Loading

qwerty287 commented Oct 24, 2021 •

edited

Loading

noerw commented Oct 24, 2021 •

edited

Loading