golint fixed for parts of routers root, dev, user and org dirs #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
approved these changes
Nov 14, 2016
|
LGTM |
|
👍 |
|
Travis failed |
bkcsoft
added
the
lgtm/need 1
bkcsoft
suggested changes
Nov 14, 2016
| @@ -11,6 +11,7 @@ import ( | |||
| "code.gitea.io/gitea/modules/setting" | |||
| ) | |||
|
|
|||
| // TemplatePreview render only on DEV mode for preview the template | |||
There was a problem hiding this comment.
This function always renders if asked, RUN_MODE is checked elsewhere
| } | ||
|
|
||
| // RepoSearchOptions options when calling search repositories |
There was a problem hiding this comment.
Maybe drop the additional options as it's redundant?
| @@ -125,6 +134,7 @@ type UserSearchOptions struct { | |||
| TplName base.TplName | |||
| } | |||
|
|
|||
| // RenderUserSearch render user search page | |||
There was a problem hiding this comment.
This could just be RenderUserSearch page :)
| EXPLORE_USERS base.TplName = "explore/users" | ||
| EXPLORE_ORGANIZATIONS base.TplName = "explore/organizations" | ||
| // TplHome home page template | ||
| TplHome base.TplName = "home" |
There was a problem hiding this comment.
Should these really be exported? 😕
| @@ -34,7 +34,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| INSTALL base.TplName = "install" | |||
| // TplInstall template for installation page | |||
| TplInstall base.TplName = "install" | |||
| MEMBERS base.TplName = "org/member/members" | ||
| MEMBER_INVITE base.TplName = "org/member/invite" | ||
| // TplMembers template for organization members page | ||
| TplMembers base.TplName = "org/member/members" |
| @@ -14,19 +14,22 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| CREATE base.TplName = "org/create" | |||
| // TplCreateOrg template path for create organization | |||
| TplCreateOrg base.TplName = "org/create" | |||
| SETTINGS_DELETE base.TplName = "org/settings/delete" | ||
| SETTINGS_HOOKS base.TplName = "org/settings/hooks" | ||
| // TplSettingsOptions template path for render settings | ||
| TplSettingsOptions base.TplName = "org/settings/options" |
| ) | ||
|
|
||
| // Settings render the main settings page |
There was a problem hiding this comment.
organization main settings page ?
| TEAM_MEMBERS base.TplName = "org/team/members" | ||
| TEAM_REPOSITORIES base.TplName = "org/team/repositories" | ||
| // TplTeams template path for teams list page | ||
| TplTeams base.TplName = "org/team/teams" |
lunny
changed the title
|
@bkcsoft Please review again. |
Current coverage is 3.03% (diff: 100%)@@ master #167 diff @@
========================================
Files 33 33
Lines 8096 8096
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
Misses 7830 7830
Partials 20 20
|
bkcsoft
reviewed
Nov 18, 2016
| @@ -34,7 +34,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| INSTALL base.TplName = "install" | |||
| // tplInstall template for installation page | |||
There was a problem hiding this comment.
no need for a comment here since it isn't exported 🙂
bkcsoft
approved these changes
Nov 18, 2016
|
LGTM |
bkcsoft
added
lgtm/done
|
resolved #70 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.