Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some API bugs #16184

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Fix some API bugs #16184

merged 3 commits into from
Jun 17, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 17, 2021

@6543 6543 added type/bug modifies/api This PR adds API routes or modifies them backport/v1.14 labels Jun 17, 2021
@6543 6543 added this to the 1.15.0 milestone Jun 17, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2021
@zeripath
Copy link
Contributor

Swagger is broken by the comment

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16184 (cbe5457) into main (29695cd) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16184   +/-   ##
=======================================
  Coverage   44.57%   44.58%           
=======================================
  Files         701      701           
  Lines       83237    83242    +5     
=======================================
+ Hits        37100    37110   +10     
+ Misses      40123    40120    -3     
+ Partials     6014     6012    -2     
Impacted Files Coverage Δ
routers/api/v1/org/org.go 63.72% <50.00%> (-0.20%) ⬇️
modules/convert/repository.go 96.42% <100.00%> (ø)
routers/api/v1/utils/utils.go 66.66% <100.00%> (ø)
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
routers/web/repo/view.go 40.73% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+5.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29695cd...cbe5457. Read the comment docs.

@6543 6543 merged commit 75205b5 into go-gitea:main Jun 17, 2021
@6543 6543 deleted the api-fix branch June 17, 2021 23:24
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 17, 2021
* Repository object only count releases as releases (fix go-gitea#16144)

* EditOrg respect RepoAdminChangeTeamAccess option (fix go-gitea#16013)
lunny pushed a commit that referenced this pull request Jun 18, 2021
* Fix some API bugs (#16184)

* Repository object only count releases as releases (fix #16144)

* EditOrg respect RepoAdminChangeTeamAccess option (fix #16013)

* adjut to v1.14
@zeripath zeripath added the backport/done All backports for this PR have been created label Jun 21, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Repository object only count releases as releases (fix go-gitea#16144)

* EditOrg respect RepoAdminChangeTeamAccess option (fix go-gitea#16013)
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
5 participants