Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-keyword class is being incorrectly stripped off spans #16163

Merged

Conversation

zeripath
Copy link
Contributor

Bluemonday sanitizer regexp rules are not additive, so the addition of the icons,
emojis and chroma syntax policy has led to this being stripped.

Signed-off-by: Andrew Thornton art27@cantab.net

Bluemonday sanitizer regexp rules are not additive, so the addition of the icons,
emojis and chroma syntax policy has led to this being stripped.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16163 (2d05d54) into main (b8e4ce7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16163      +/-   ##
==========================================
- Coverage   44.58%   44.58%   -0.01%     
==========================================
  Files         699      699              
  Lines       82795    82794       -1     
==========================================
- Hits        36916    36912       -4     
- Misses      39899    39901       +2     
- Partials     5980     5981       +1     
Impacted Files Coverage Δ
modules/markup/sanitizer.go 91.22% <100.00%> (-0.16%) ⬇️
models/gpg_key.go 51.42% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e4ce7...2d05d54. Read the comment docs.

@6543
Copy link
Member

6543 commented Jun 16, 2021

🚀

@6543 6543 merged commit f4d3bf7 into go-gitea:main Jun 16, 2021
@zeripath zeripath deleted the bluemonday-sanitizer-rules-arent-additive branch June 16, 2021 06:24
zeripath added a commit to zeripath/gitea that referenced this pull request Jun 16, 2021
…#16163)

Backport go-gitea#16163

Bluemonday sanitizer regexp rules are not additive, so the addition of the icons,
emojis and chroma syntax policy has led to this being stripped.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Jun 16, 2021
techknowlogick pushed a commit that referenced this pull request Jun 16, 2021
…16172)

Backport #16163

Bluemonday sanitizer regexp rules are not additive, so the addition of the icons,
emojis and chroma syntax policy has led to this being stripped.

Signed-off-by: Andrew Thornton <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
…#16163)

Bluemonday sanitizer regexp rules are not additive, so the addition of the icons,
emojis and chroma syntax policy has led to this being stripped.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants