Add support for corporate WeChat webhooks #15910

lengyuqu · 2021-05-17T17:02:48Z

这是一个企业微信的webhook 功能
1，提供了企业微信的webhook推送。
这对中国的工作者是有帮助的。这个功能我已经在我的公司使用了一年，由于中国的网络问题，一直没办法进行提交，希望可以获得合并。谢谢

This is a WebHook function of a company WeChat

Provide WebHook push for corporate WeChat.
This is helpful for Chinese workers. This feature I have been in my company for a year, because China's network problems have not been submitted, I hope I can get mergers. Thank you

docs/content/doc/features/webhooks.en-us.md

options/locale/locale_zh-CN.ini

services/webhook/wechatwork.go

templates/admin/hook_new.tmpl

Co-authored-by: a1012112796 <1012112796@qq.com>

a1012112796 · 2021-05-19T01:55:24Z

Please fix lint

5	templates/admin/hook_new.tmpl:
30s
6		36: Wrong indentation type(spaces instead of tabs)
30s
7	templates/org/settings/hook_new.tmpl:
30s
8		31: Wrong indentation type(spaces instead of tabs)
30s
9	templates/repo/settings/webhook/base_list.tmpl:
30s
10		35: Wrong indentation type(spaces instead of tabs)
30s
11		36: Wrong indentation type(spaces instead of tabs)
30s
12	templates/repo/settings/webhook/new.tmpl:
30s
13		29: Wrong indentation type(spaces instead of tabs)

	services/webhook/wechatwork.go:61:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
4	func (f *WechatworkPayload) Create(p *api.CreatePayload) (api.Payloader, error) {
162s
5	^
162s
6	services/webhook/wechatwork.go:70:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
7	func (f *WechatworkPayload) Delete(p *api.DeletePayload) (api.Payloader, error) {
162s
8	^
162s
9	services/webhook/wechatwork.go:81:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
10	func (f *WechatworkPayload) Fork(p *api.ForkPayload) (api.Payloader, error) {
162s
11	^
162s
12	services/webhook/wechatwork.go:105:3: S1021: should merge variable declaration with assignment on next line (gosimple)
162s
13			var message string
162s
14			^
162s
15	services/webhook/wechatwork.go:146:2: S1021: should merge variable declaration with assignment on next line (gosimple)
162s
16		var pr string
162s
17		^
162s
18	make: *** [Makefile:762: golangci-lint] Error 1

routers/routes/web.go

services/webhook/wechatwork.go

lengyuqu · 2021-05-19T03:03:27Z

请修理皮棉

5	templates/admin/hook_new.tmpl:
30s
6		36: Wrong indentation type(spaces instead of tabs)
30s
7	templates/org/settings/hook_new.tmpl:
30s
8		31: Wrong indentation type(spaces instead of tabs)
30s
9	templates/repo/settings/webhook/base_list.tmpl:
30s
10		35: Wrong indentation type(spaces instead of tabs)
30s
11		36: Wrong indentation type(spaces instead of tabs)
30s
12	templates/repo/settings/webhook/new.tmpl:
30s
13		29: Wrong indentation type(spaces instead of tabs)

	services/webhook/wechatwork.go:61:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
4	func (f *WechatworkPayload) Create(p *api.CreatePayload) (api.Payloader, error) {
162s
5	^
162s
6	services/webhook/wechatwork.go:70:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
7	func (f *WechatworkPayload) Delete(p *api.DeletePayload) (api.Payloader, error) {
162s
8	^
162s
9	services/webhook/wechatwork.go:81:1: receiver name f should be consistent with previous receiver name p for WechatworkPayload (golint)
162s
10	func (f *WechatworkPayload) Fork(p *api.ForkPayload) (api.Payloader, error) {
162s
11	^
162s
12	services/webhook/wechatwork.go:105:3: S1021: should merge variable declaration with assignment on next line (gosimple)
162s
13			var message string
162s
14			^
162s
15	services/webhook/wechatwork.go:146:2: S1021: should merge variable declaration with assignment on next line (gosimple)
162s
16		var pr string
162s
17		^
162s
18	make: *** [Makefile:762: golangci-lint] Error 1

It has been fixed

options/locale/locale_cs-CZ.ini

fix

…6049) * Add checkbox to delete pull branch after successful merge * Omit DeleteBranchAfterMerge field in json * Log a warning instead of error when PR head branch deleted * Add DefaultDeleteBranchAfterMerge to PullRequestConfig * Add support for delete_branch_after_merge via API * Fix for API: the branch should be deleted from the HEAD repo If head and base repo are the same, reuse the already opened ctx.Repo.GitRepo * Don't delegate to CleanupBranch, only reuse branch deletion code CleanupBranch contains too much logic that has already been performed by the Merge * Reuse gitrepo in MergePullRequest Co-authored-by: Andrew Thornton <art27@cantab.net>

* Detect encoding changes while parsing diff

* fix go-gitea#16384# * refactor: move shared helper func to utils package * extend Tests * use ctx.Repo.GitRepo if not nil

lengyuqu · 2021-07-13T11:48:22Z

@lenyuqu lint 失败。

I'm fixing this problem.

docs/content/doc/features/webhooks.zh-cn.md

* 企业微信webhook * 企业微信webhook * 企业微信webhook * Update templates/admin/hook_new.tmpl Co-authored-by: a1012112796 <1012112796@qq.com> * Update services/webhook/wechatwork.go Co-authored-by: a1012112796 <1012112796@qq.com> * 修善wechatwork * 修善wechatwork * fix * Update locale_cs-CZ.ini fix * fix build * fix * fix build * make webhooks.zh-cn.md * delet unnecessary blank line * delet unnecessary blank line * 企业微信webhook * 企业微信webhook * 企业微信webhook * Update templates/admin/hook_new.tmpl Co-authored-by: a1012112796 <1012112796@qq.com> * Update services/webhook/wechatwork.go Co-authored-by: a1012112796 <1012112796@qq.com> * 修善wechatwork * 修善wechatwork * fix * fix build * fix * fix build * make webhooks.zh-cn.md * delet unnecessary blank line * delet unnecessary blank line * 企业微信webhook * 企业微信webhook * 企业微信webhook * 企业微信webhook * 企业微信webhook * fix * fix * 企业微信webhook * 企业微信webhook * 企业微信webhook * fix wechat * fix wechat * fix wechat * fix wechat * Fix invalid params and typo of email templates (go-gitea#16394) Signed-off-by: Meano <meanocat@gmail.com> * Add LRU mem cache implementation (go-gitea#16226) The current default memory cache implementation is unbounded in size and number of objects cached. This is hardly ideal. This PR proposes creating a TwoQueue LRU cache as the underlying cache for Gitea. The cache is limited by the number of objects stored in the cache (rather than size) for simplicity. The default number of objects is 50000 - which is perhaps too small as most of our objects cached are going to be much less than 1kB. It may be worth considering using a different LRU implementation that actively limits sizes or avoids GC - however, this is just a beginning implementation. Signed-off-by: Andrew Thornton <art27@cantab.net> * [skip ci] Updated translations via Crowdin * Replace `plugins/docker` with `techknowlogick/drone-docker`in ci (go-gitea#16407) * plugins/docker -> techknowlogick/drone-docker * It is multi-arch * docs: rewrite email setup (go-gitea#16404) * Add intro for both the docs page and mailer methods * Fix numbering level in SMTP section * Recommends implicit TLS Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> * Validate Issue Index before querying DB (go-gitea#16406) * Fix external renderer (go-gitea#16401) * fix external renderer * use GBackground context as fallback * no fallback, return error Co-authored-by: Lauris BH <lauris@nix.lv> * Add checkbox to delete pull branch after successful merge (go-gitea#16049) * Add checkbox to delete pull branch after successful merge * Omit DeleteBranchAfterMerge field in json * Log a warning instead of error when PR head branch deleted * Add DefaultDeleteBranchAfterMerge to PullRequestConfig * Add support for delete_branch_after_merge via API * Fix for API: the branch should be deleted from the HEAD repo If head and base repo are the same, reuse the already opened ctx.Repo.GitRepo * Don't delegate to CleanupBranch, only reuse branch deletion code CleanupBranch contains too much logic that has already been performed by the Merge * Reuse gitrepo in MergePullRequest Co-authored-by: Andrew Thornton <art27@cantab.net> * [skip ci] Updated translations via Crowdin * Detect encoding changes while parsing diff (go-gitea#16330) * Detect encoding changes while parsing diff * Let branch/tag name be a valid ref to get CI status (go-gitea#16400) * fix go-gitea#16384# * refactor: move shared helper func to utils package * extend Tests * use ctx.Repo.GitRepo if not nil * fix * fix * 企业微信webhook * 企业微信webhook * 企业微信webhook * fix build * fix build * Apply suggestions from code review Co-authored-by: a1012112796 <1012112796@qq.com> Co-authored-by: myheavily <myheavily> Co-authored-by: zhaoxin <gitea@fake.local> Co-authored-by: Meano <Meano@foxmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: GiteaBot <teabot@gitea.io> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Bagas Sanjaya <bagasdotme@gmail.com> Co-authored-by: Norwin <noerw@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Jimmy Praet <jimmy.praet@telenet.be> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

lengyuqu added 4 commits May 17, 2021 23:39

企业微信webhook

12c9224

企业微信webhook

75f0f17

企业微信webhook

5112a6e

Merge branch 'go-gitea:main' into master

49c9678

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2021

Merge branch 'main' into master

254aaa6

delvh reviewed May 18, 2021

View reviewed changes

docs/content/doc/features/webhooks.en-us.md Outdated Show resolved Hide resolved

a1012112796 reviewed May 18, 2021

View reviewed changes

options/locale/locale_zh-CN.ini Show resolved Hide resolved

a1012112796 reviewed May 18, 2021

View reviewed changes

services/webhook/wechatwork.go Outdated Show resolved Hide resolved

a1012112796 reviewed May 18, 2021

View reviewed changes

templates/admin/hook_new.tmpl Outdated Show resolved Hide resolved

a1012112796 added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 18, 2021

lengyuqu and others added 3 commits May 18, 2021 21:40

Update templates/admin/hook_new.tmpl

701cee8

Co-authored-by: a1012112796 <1012112796@qq.com>

Update services/webhook/wechatwork.go

2ede040

Co-authored-by: a1012112796 <1012112796@qq.com>

修善wechatwork

dd25990

go-gitea deleted a comment from lengyuqu May 19, 2021

lunny reviewed May 19, 2021

View reviewed changes

routers/routes/web.go Outdated Show resolved Hide resolved

lunny reviewed May 19, 2021

View reviewed changes

services/webhook/wechatwork.go Show resolved Hide resolved

修善wechatwork

84fd130

lengyuqu added 3 commits May 20, 2021 17:31

Merge branch 'go-gitea:main' into master

40763c2

Merge branch 'main' into master

b6166e5

Merge branch 'go-gitea:main' into master

eda8b88

lunny reviewed May 29, 2021

View reviewed changes

options/locale/locale_cs-CZ.ini Show resolved Hide resolved

zhaoxin and others added 2 commits June 1, 2021 15:33

fix

4fc7d6c

Update locale_cs-CZ.ini

b17eeb1

fix

techknowlogick changed the title ~~Created a corporate WeChat~~ Add support for corporate WeChat webhooks Jun 2, 2021

lengyuqu and others added 3 commits June 2, 2021 13:28

Merge branch 'go-gitea:main' into master

6242c08

Merge branch 'go-gitea:main' into master

d161fc3

Merge branch 'master' of https://github.com/lengyuqu/gitea

302c5ec

jpraet and others added 12 commits July 13, 2021 18:16

[skip ci] Updated translations via Crowdin

b04748d

Detect encoding changes while parsing diff (go-gitea#16330)

a748490

* Detect encoding changes while parsing diff

Let branch/tag name be a valid ref to get CI status (go-gitea#16400)

5fa390a

* fix go-gitea#16384# * refactor: move shared helper func to utils package * extend Tests * use ctx.Repo.GitRepo if not nil

fix

14ddbc8

fix

47a8e0e

企业微信webhook

75855d5

企业微信webhook

f1fbdd1

企业微信webhook

f53d723

fix build

dffb2af

Merge branch 'main' into master

fdc4633

fix build

4861d91

lengyuqu added 2 commits July 15, 2021 20:59

Merge branch 'go-gitea:main' into master

6b3f71c

Merge branch 'main' into master

2fe8e10

lunny approved these changes Jul 21, 2021

View reviewed changes

Merge branch 'main' into master

9d0ef12

6543 approved these changes Jul 21, 2021

View reviewed changes

docs/content/doc/features/webhooks.zh-cn.md Outdated Show resolved Hide resolved

docs/content/doc/features/webhooks.zh-cn.md Show resolved Hide resolved

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 21, 2021

6543 and others added 2 commits July 21, 2021 08:11

Apply suggestions from code review

b1e45aa

Merge branch 'main' into master

e5b6888

a1012112796 removed their request for review July 23, 2021 04:00

lunny merged commit 078e2b2 into go-gitea:main Jul 23, 2021

This was referenced Jul 23, 2021

WIP: Webhook wechat #9746

Closed

Haven't considered adding webhook for corporate WeChat？ #10847

Closed

jolheiser mentioned this pull request Oct 14, 2021

Cant find wechatwork webhook #17309

Closed

go-gitea locked and limited conversation to collaborators Oct 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for corporate WeChat webhooks #15910

Add support for corporate WeChat webhooks #15910

lengyuqu commented May 17, 2021

a1012112796 commented May 19, 2021

lengyuqu commented May 19, 2021

lengyuqu commented Jul 13, 2021

Add support for corporate WeChat webhooks #15910

Add support for corporate WeChat webhooks #15910

Conversation

lengyuqu commented May 17, 2021

a1012112796 commented May 19, 2021

lengyuqu commented May 19, 2021

lengyuqu commented Jul 13, 2021