Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only offer hostcertificates if they exist (#15849) #15853

Merged
merged 2 commits into from
May 13, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 13, 2021

Backport #15849

A common bug report is the otherwise harmless sshd logging:

Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory

This PR simply checks if these files exist before creation of sshd_config and if
they do not exist, doesn't add a reference to them.

Close #14110
Close #13724

Signed-off-by: Andrew Thornton art27@cantab.net

Co-authored-by: silverwind me@silverwind.io

Backport go-gitea#15849

A common bug report is the otherwise harmless sshd logging:

```
Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory
```

This PR simply checks if these files exist before creation of sshd_config and if
they do not exist, doesn't add a reference to them.

Fix go-gitea#14110 amongst others.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
@zeripath zeripath added this to the 1.14.3 milestone May 13, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 13, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2021
@techknowlogick techknowlogick merged commit 1bf4683 into go-gitea:release/v1.14 May 13, 2021
@zeripath zeripath deleted the backport-15849-v1.14 branch May 13, 2021 15:17
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@delvh delvh added topic/distribution This PR changes something about the packaging of Gitea and removed theme/docker labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants