-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bound address/port for caddy's certmagic library #15758
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15758 +/- ##
==========================================
- Coverage 43.93% 43.93% -0.01%
==========================================
Files 678 678
Lines 81945 81950 +5
==========================================
- Hits 36005 36004 -1
- Misses 40069 40075 +6
Partials 5871 5871
Continue to review full report at Codecov.
|
the thing is certmagic shouldn't be opening any ports itself. We open and control these ports ourselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per zeripath, we should find out why certmagic would (if ..) open a port itself and consider it a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ListenHost and AltHTTPPort are used in the challenge solvers - that's why they're needed
make lgtm work |
Backport go-gitea#15758 * Fix bound address/port for caddy's certmagic library * Fix bug Co-authored-by: zeripath <art27@cantab.net>
* Fix bound address/port for caddy's certmagic library * Fix bug Co-authored-by: zeripath <art27@cantab.net>
This is my attempt to fix issue created by d2ea21d when switching to Caddy's certmagic library. I believe that the call to
ManageSync
causes Gitea to try and listen on port 80 even ifPortToRedirect
is set.Please test this fix, but I think it works. Thoughts?