Return go-get info on subdirs #15642

zeripath · 2021-04-27T19:41:13Z

This PR is an alternative to #15628 and makes the go get handler a
handler.

Signed-off-by: Andrew Thornton art27@cantab.net

This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <art27@cantab.net>

jolheiser · 2021-04-27T20:17:15Z

routers/routes/goget.go

+	"code.gitea.io/gitea/modules/context"
+	"code.gitea.io/gitea/modules/setting"
+	"code.gitea.io/gitea/modules/util"
+	"github.com/unknwon/com"


Just because you're already fiddling here, maybe we could replace com.Expand with os.Expand? 🙂

it's doing something different from os.Expand.

It might be better to actually change this to use a go-template instead.

Both are used to expand variables in strings. A template would also work.

routers/routes/goget.go

lunny · 2021-04-28T12:13:36Z

It seems this still not resolve the sub dir problem. And I think with a test is better.

zeripath · 2021-04-28T17:23:01Z

@lunny what do you mean it does not resolve the subdir problem?

What are you expecting and what are you testing?

…ndler

zeripath · 2021-04-28T17:40:56Z

With this patch as it stands:

> curl 'http://localhost/gitea/administrator/admin/asjdaljsda?go-get=1'                      [18:40:08]
<!doctype html>
<html>
	<head>
		<meta name="go-import" content="localhost/gitea/administrator/admin git http://localhost/gitea/administrator/admin.git">
		<meta name="go-source" content="localhost/gitea/administrator/admin _ http://localhost/gitea/administrator/admin/src/branch/master{/dir} http://localhost/gitea/administrator/admin/src/branch/master{/dir}/{file}#L{line}">
	</head>
	<body>
		go get --insecure localhost/gitea/administrator/admin
	</body>
</html>

6543 · 2021-04-30T19:39:15Z

I like the refactor ... can we still get some simple tests ;)

zeripath · 2021-04-30T21:29:12Z

if you could tell me what this is actually supposed to return then a numbskull test would be possible but I don't understand whether it is doing the correct thing

…into fix-15625-go-get-handler

Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath · 2021-05-09T17:55:59Z

Test case added and conflicts resolved

codecov-commenter · 2021-05-09T18:49:46Z

Codecov Report

Merging #15642 (dd61d75) into main (a2df265) will decrease coverage by 0.02%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main   #15642      +/-   ##
==========================================
- Coverage   43.97%   43.95%   -0.03%     
==========================================
  Files         678      679       +1     
  Lines       82047    82051       +4     
==========================================
- Hits        36081    36062      -19     
- Misses      40082    40119      +37     
+ Partials     5884     5870      -14

Impacted Files	Coverage Δ
routers/routes/goget.go	`70.21% <70.21%> (ø)`
routers/routes/web.go	`90.84% <100.00%> (+4.35%)`	⬆️
modules/notification/mail/mail.go	`33.67% <0.00%> (-8.17%)`	⬇️
modules/notification/ui/ui.go	`58.97% <0.00%> (-6.84%)`	⬇️
models/issue_comment.go	`46.69% <0.00%> (-5.90%)`	⬇️
models/unit.go	`46.57% <0.00%> (-2.74%)`	⬇️
modules/notification/base/null.go	`76.31% <0.00%> (-2.64%)`	⬇️
modules/notification/notification.go	`85.12% <0.00%> (-2.48%)`	⬇️
modules/log/event.go	`59.90% <0.00%> (-1.89%)`	⬇️
models/notification.go	`65.18% <0.00%> (-0.89%)`	⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2df265...dd61d75. Read the comment docs.

zeripath · 2021-05-09T21:49:12Z

Make lgtm work

Backport go-gitea#15642 This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <art27@cantab.net>

Backport #15642 This PR is an alternative to #15628 and makes the go get handler a handler. Fix #15625 Close #15628 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>

This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <art27@cantab.net>

Return go-get info on subdirs

9ace36a

This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added type/bug backport/v1.14 labels Apr 27, 2021

zeripath added this to the 1.15.0 milestone Apr 27, 2021

jolheiser reviewed Apr 27, 2021

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2021

jolheiser reviewed Apr 27, 2021

View reviewed changes

routers/routes/goget.go Show resolved Hide resolved

techknowlogick added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Apr 27, 2021

Merge remote-tracking branch 'origin/master' into fix-15625-go-get-ha…

2e379de

…ndler

techknowlogick approved these changes May 3, 2021

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 3, 2021

zeripath added 4 commits May 3, 2021 22:32

Merge branch 'master' into fix-15625-go-get-handler

c9570e5

Merge branch 'fix-15625-go-get-handler' of github.com:zeripath/gitea …

ce705a7

…into fix-15625-go-get-handler

Merge remote-tracking branch 'origin/main' into fix-15625-go-get-handler

ac9d4ab

add testcase as per 6543

dd61d75

Signed-off-by: Andrew Thornton <art27@cantab.net>

Merge branch 'main' into fix-15625-go-get-handler

f9f502a

6543 approved these changes May 9, 2021

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021

Merge branch 'main' into fix-15625-go-get-handler

cf2eea9

zeripath merged commit 038e1db into go-gitea:main May 9, 2021

zeripath deleted the fix-15625-go-get-handler branch May 9, 2021 21:50

zeripath mentioned this pull request May 14, 2021

Return go-get info on subdirs (#15642) #15871

Merged

zeripath added the backport/done All backports for this PR have been created label May 14, 2021

go-gitea locked and limited conversation to collaborators Oct 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return go-get info on subdirs #15642

Return go-get info on subdirs #15642

zeripath commented Apr 27, 2021

jolheiser Apr 27, 2021

zeripath Apr 27, 2021

jolheiser Apr 27, 2021

lunny commented Apr 28, 2021

zeripath commented Apr 28, 2021

zeripath commented Apr 28, 2021

6543 commented Apr 30, 2021

zeripath commented Apr 30, 2021

zeripath commented May 9, 2021

codecov-commenter commented May 9, 2021

zeripath commented May 9, 2021

Return go-get info on subdirs #15642

Return go-get info on subdirs #15642

Conversation

zeripath commented Apr 27, 2021

jolheiser Apr 27, 2021

Choose a reason for hiding this comment

zeripath Apr 27, 2021

Choose a reason for hiding this comment

jolheiser Apr 27, 2021

Choose a reason for hiding this comment

lunny commented Apr 28, 2021

zeripath commented Apr 28, 2021

zeripath commented Apr 28, 2021

6543 commented Apr 30, 2021

zeripath commented Apr 30, 2021

zeripath commented May 9, 2021

codecov-commenter commented May 9, 2021

Codecov Report

zeripath commented May 9, 2021