Resolve Object { type: "error", data: undefined } in stopwatch.js

[kdumontnu]

type of stopwatchEl is JQuery<HTMLElement> returned by $('.active-stopwatch-trigger').

Resolves spamming of

Object { type: "error", data: undefined }
stopwatch.js:48:16

when the stopwatch doesn't exist (such as when a user is not logged in).

[codecov-io]

Codecov Report

Merging #15278 (ac82df6) into master (487f2ee) will increase coverage by 1.42%.
The diff coverage is 49.54%.

@@            Coverage Diff             @@
##           master   #15278      +/-   ##
==========================================
+ Coverage   42.21%   43.64%   +1.42%     
==========================================
  Files         767      671      -96     
  Lines       81624    81007     -617     
==========================================
+ Hits        34458    35355     +897     
+ Misses      41531    39917    -1614     
- Partials     5635     5735     +100     

Impacted Files	Coverage Δ
cmd/dump.go	0.93% <0.00%> (-0.01%)	⬇️
cmd/serv.go	2.61% <0.00%> (-0.02%)	⬇️
cmd/web.go	0.00% <0.00%> (ø)
cmd/web_graceful.go	0.00% <0.00%> (ø)
cmd/web_letsencrypt.go	0.00% <0.00%> (ø)
models/admin.go	60.31% <ø> (ø)
models/commit_status.go	61.74% <0.00%> (ø)
models/consistency.go	36.26% <0.00%> (-16.68%)	⬇️
models/fixture_generation.go	70.00% <ø> (ø)
models/helper_environment.go	93.33% <ø> (ø)
... and 323 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2715b8...ac82df6. Read the comment docs.

[zeripath]

Hi @kdumontnu I think #15275 is actually the solution.

[kdumontnu]

Hi @kdumontnu I think #15275 is actually the solution.

Nice. Looks like that solves the broader issue of the repeated event firing. However, I still believe this PR is valid.

As I understand it, the logic in stopwatch.js intends to return if it doesn't find $('.active-stopwatch-trigger'), which it currently fails to do & instead continues to register the even handlers.

[zeripath]

Does notification.js also require this too?

[kdumontnu]

Does notification.js also require this too?

No, it uses the proper check for .length:

gitea/web_src/js/features/notification.js

Line 42 in 48ef04e

if (!notificationCount.length) {

[silverwind]

Suggested change

	if (!stopwatchEl || !stopwatchEl.length) {
	if (!stopwatchEl.length) {

[silverwind]

I think these checks should be moved right after const stopwatchEl.