Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response 404 for diff/patch of a commit that not exist (#15221) #15237

Merged
merged 3 commits into from
Apr 1, 2021
Merged

response 404 for diff/patch of a commit that not exist (#15221) #15237

merged 3 commits into from
Apr 1, 2021

Conversation

a1012112796
Copy link
Member

Backport #15221

@a1012112796 @zeripath @silverwind
response 404 for diff/patch of a commit that not exist (go-gitea#15221)
31f387d 
* response 404 for diff/patch of a commit that not exist

fix go-gitea#15217

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update routers/repo/commit.go

Co-authored-by: silverwind <me@silverwind.io>

* use ctx.NotFound()

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
@a1012112796 a1012112796 added this to the 1.14.0 milestone Apr 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit c6eb9b3 into go-gitea:release/v1.14 Apr 1, 2021
@a1012112796 a1012112796 deleted the backport/15221 branch April 2, 2021 00:58
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@a1012112796 @techknowlogick @noerw @6543 @GiteaBot