Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heatmap fixtures to restore tests #13224

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 20, 2020

just another #8615

@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 20, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 20, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2020
integrations/api_user_heatmap_test.go Outdated Show resolved Hide resolved
models/user_heatmap_test.go Outdated Show resolved Hide resolved
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 20, 2020
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 20, 2020
@6543
Copy link
Member Author

6543 commented Oct 20, 2020

@6543 6543 added the backport/done All backports for this PR have been created label Oct 20, 2020
@silverwind
Copy link
Member

Wonder if this can be solved by either calculating the expected date based on the current year or somehow mocking the responsible date function.

@jolheiser
Copy link
Member

I think the Go code tests could be fixed this way, but I'm uncertain what to do with the fixture. It likely needs to be refactored.

@6543
Copy link
Member Author

6543 commented Oct 20, 2020

🚀

@jolheiser jolheiser merged commit 48a8009 into go-gitea:master Oct 20, 2020
jolheiser pushed a commit that referenced this pull request Oct 20, 2020
jolheiser pushed a commit that referenced this pull request Oct 20, 2020
@6543 6543 deleted the hotfix branch October 20, 2020 22:40
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 21, 2020
…ments-in-pull-request-label-style

* origin/master: (27 commits)
  [skip ci] Updated translations via Crowdin
  add more clarification to the issue-template.md (go-gitea#13235)
  go-version constraints ignore pre-releases (go-gitea#13234)
  [skip ci] Updated translations via Crowdin
  Update some JS dependencies (go-gitea#13222)
  Return the full rejection message and errors in flash errors (go-gitea#13221)
  Update heatmap fixtures to restore tests (go-gitea#13224)
  [skip ci] Updated translations via Crowdin
  Add review request api (go-gitea#11355)
  [skip ci] Updated translations via Crowdin
  When the git ref is unable to be found return broken pr (go-gitea#13218)
  Various arc-green fixes (go-gitea#13214)
  Show stale label for stale code comment which is marked as resolved (go-gitea#13213)
  Move install pages out of main macaron routes (go-gitea#13195)
  Use CSS Variables for fonts, remove postcss-loader (go-gitea#13204)
  [skip ci] Updated translations via Crowdin
  Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (go-gitea#13212)
  Fix size and clickable area on file table back link (go-gitea#13205)
  [skip ci] Updated translations via Crowdin
  Fix error in diff html rendering (go-gitea#13191)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants