Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milestone API state parameter unhandled #10049

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Fix milestone API state parameter unhandled #10049

merged 2 commits into from
Jan 29, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 29, 2020

Fix #10047

@lunny lunny added this to the 1.12.0 milestone Jan 29, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #10049 into master will increase coverage by 0.08%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10049      +/-   ##
==========================================
+ Coverage   42.28%   42.36%   +0.08%     
==========================================
  Files         618      618              
  Lines       80742    80761      +19     
==========================================
+ Hits        34138    34215      +77     
+ Misses      42403    42338      -65     
- Partials     4201     4208       +7
Impacted Files Coverage Δ
routers/repo/milestone.go 0% <0%> (ø) ⬆️
models/issue_milestone.go 67.61% <44.44%> (-0.29%) ⬇️
routers/api/v1/repo/milestone.go 32.22% <80%> (+32.22%) ⬆️
modules/queue/workerpool.go 45.55% <0%> (-1.07%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
models/repo.go 49.79% <0%> (+0.13%) ⬆️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29c301...a258752. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
@lafriks lafriks merged commit c09e020 into go-gitea:master Jan 29, 2020
@lafriks
Copy link
Member

lafriks commented Jan 29, 2020

Please send backports

@lunny lunny deleted the lunny/fix_milestone_api branch January 29, 2020 08:00
lunny added a commit to lunny/gitea that referenced this pull request Jan 29, 2020
@lunny
Fix milestone API state parameter unhandled (go-gitea#10049)
34eb508 
* Fix milestone API state parameter unhandled

* Fix test
lunny added a commit to lunny/gitea that referenced this pull request Jan 29, 2020
@lunny
Fix milestone API state parameter unhandled (go-gitea#10049)
b5c3d79 
* Fix milestone API state parameter unhandled

* Fix test
This was referenced Jan 29, 2020
Merged
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jan 29, 2020
lafriks pushed a commit that referenced this pull request Jan 29, 2020
@lunny
Fix milestone API state parameter unhandled (#10049) (#10052)
491cbec 
* Fix milestone API state parameter unhandled

* Fix test
lunny added a commit that referenced this pull request Jan 30, 2020
@lunny
Fix milestone API state parameter unhandled (#10049) (#10053)
0c5e2e2 
* Fix milestone API state parameter unhandled (#10049)

* Fix milestone API state parameter unhandled

* Fix test

* Fix test
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Bug] [API] cant close milestone
5 participants
@lunny @codecov-io @lafriks @zeripath @GiteaBot