Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename existing unix protocol to http+unix #9318

Closed
clarfonthey opened this issue Dec 11, 2019 · 0 comments · Fixed by #17771
Closed

Rename existing unix protocol to http+unix #9318

clarfonthey opened this issue Dec 11, 2019 · 0 comments · Fixed by #17771
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@clarfonthey
Copy link
Contributor

With #9298 there is now an fcgi+unix protocol which allows serving FastCGI via a unix socket.

Personally, I feel that it makes sense to rename the existing unix to http+unix. We can still accept unix, just warning that it's defaulting to http+unix and that you should probably use http+unix instead.
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 11, 2019
@mscherer mscherer mentioned this issue Nov 22, 2021
Merged
mscherer added a commit to mscherer/gitea that referenced this issue Dec 1, 2021
@mscherer
Replace "unix" by "http+unix" for PROTOCOL
f8bc86b 
Fixes go-gitea#9318
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "unix" by "http+unix" for PROTOCOL mscherer/gitea
2 participants
@lunny @clarfonthey