Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect go vesion on makefile #9216

Closed
lunny opened this issue Dec 1, 2019 · 1 comment
Closed

Detect go vesion on makefile #9216

lunny opened this issue Dec 1, 2019 · 1 comment
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Comments

@lunny
Copy link
Member

lunny commented Dec 1, 2019

Some user with go1.10 to make build and no version hint to them.
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 1, 2019
@silverwind
Copy link
Member

silverwind commented Dec 2, 2019 •
edited
Loading

Adressed this in #9114.

silverwind added a commit to silverwind/gitea that referenced this issue Dec 4, 2019
@silverwind
Add Node.js build dep, remove built js/css files
dd36827 
- Added Node.js as build dependency and removes build files from git.
- Added version checks for both Go and Node.js.
- Overhauled the js/css make target to only run when needed.
- Merged the `generate` make target into `build` as per suggestion.

Fixes: go-gitea#6782
Fixes: go-gitea#9216
@lunny lunny closed this as completed in d9c67a8 Dec 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @silverwind