Cannot upload jar file

[tomposmiko]

• Gitea version (or commit ref): 1.8.3
• Operating system: Ubuntu 18.04
• Database (use [x]):
  • PostgreSQL
  • [ x] MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Despite this setting:
ALLOWED_TYPES = image/jpeg|image/png|application/zip|application/gzip|application/java-archive

I does not allow upload jar files.
If I set /, then the upload is allowed.

application/* also does not allow me to do that.

What should be the appropriate setting?
...

Screenshots

[PedroAS7]

application/java-archive not working on Gitea 1.9.0 either

[tomposmiko]

What is the severity of this issue from your perspective?

[lunny]

Where did you upload? Releases or issues?

[lunny]

There are two allowed_types, you may changed the wrong section. I uploaded successfully on my local instance both the releases and issues.

[repository.upload]
ALLOWED_TYPES = "application/zip|application/gzip|application/x-gzip|application/x-gtar|application/x-tgz|application/x-compressed-tar|application/java-archive"

[attachment]
ALLOWED_TYPES = "application/zip|application/gzip|application/x-gzip|application/x-gtar|application/x-tgz|application/x-compressed-tar|application/java-archive"

[tomposmiko]

Where did you upload? Releases or issues?

releases

[tomposmiko]

Hmm, this is interesting.

$ mkdir -p data/tmp/uploads
$ chown ...
$ service gitea restart

And it starts working.
However, after second restart, it stops working, because the tmp directory is gone!
In fact I investigated the following scenarios:

1. no [repsitory.upload] section in app.ini
   -> no success, even if the directory is created.

[repository.upload]
ENABLED = true
TEMP_PATH = data/tmp/uploads
FILE_MAX_SIZE = 3
MAX_FILES = 5
ALLOWED_TYPES = image/jpeg|image/png|application/zip|application/gzip|application/java-archive

It works after first service restart if the directory is created. It does not work after the second restart, the tmp directory is gone.

3. [repository.upload]
   ENABLED = true
   TEMP_PATH = /data/gitea/data/tmp/uploads
   FILE_MAX_SIZE = 3
   MAX_FILES = 5
   ALLOWED_TYPES = image/jpeg|image/png|application/zip|application/gzip|application/java-archive

Directory created, service restarted.
No success

4. TEMP_PATH = tmp/uploads
   Directory created, service restarted.
   No success

So I got lost, I have no idea

[lafriks]

You should try mount tmp as volume in docker

[tomposmiko]

I don't use docker.

[tomposmiko]

Hmm, this is interesting.

$ mkdir -p data/tmp/uploads
$ chown ...
$ service gitea restart

And it starts working.
However, after second restart, it stops working, because the tmp directory is gone!
In fact I investigated the following scenarios:

1. no [repsitory.upload] section in app.ini
   -> no success, even if the directory is created.

[repository.upload]
ENABLED = true
TEMP_PATH = data/tmp/uploads
FILE_MAX_SIZE = 3
MAX_FILES = 5
ALLOWED_TYPES = image/jpeg|image/png|application/zip|application/gzip|application/java-archive

It works after first service restart if the directory is created. It does not work after the second restart, the tmp directory is gone.

3. [repository.upload]
   ENABLED = true
   TEMP_PATH = /data/gitea/data/tmp/uploads
   FILE_MAX_SIZE = 3
   MAX_FILES = 5
   ALLOWED_TYPES = image/jpeg|image/png|application/zip|application/gzip|application/java-archive

Directory created, service restarted.
No success

4. TEMP_PATH = tmp/uploads
   Directory created, service restarted.
   No success

So I got lost, I have no idea

[tomposmiko]

Is it a bug or do I miss something?

[sapk]

Gitea should support upload of java archive so it must be a configuration or system problem.
To be able to debug, do you have any log of the failed upload ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[reikjarloekl]

I have the same issue but with .zip files. Can be reproduced on try.giteo.io using a Windows 10 PC and Chrome or Firefox.
It works using iOS! So apparently, mime type is set differently/ incorrectly using Windows 10/ Chrome or Firefox?

[sapk]

Yes, It is possible that browser/os use different value. You can debug the mime type in gitea log or with the network inspector on firefox and chrome.
For Chrome: https://developers.google.com/web/tools/chrome-devtools/network#load

[reikjarloekl]

There is no activity in the network tab. Possibly the javascript is already blocking the file from being uploaded?

[sapk]

You need to open the network tab before uploading the file

[reikjarloekl]

I did...

[zeripath]

It'll be dropzone.js that is blocking the zip directly.

[dochan-consultis]

I have also same issue with zip files. It is because of mime-types from code of dropzone.js. Allowed are these image/jpeg,image/png,application/zip,application/gzip and from Win10 with chrome when uploading zip is application/x-zip-compressed.