Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions pagination is broken for wiki pages #31755

Closed
na-Itms opened this issue Aug 1, 2024 · 0 comments · Fixed by #31760
Closed

Revisions pagination is broken for wiki pages #31755

na-Itms opened this issue Aug 1, 2024 · 0 comments · Fixed by #31760
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.2

Comments

@na-Itms
Copy link

na-Itms commented Aug 1, 2024

Description

When viewing the revision history of wiki pages, the pagination links are broken: instead of org/repo/wiki/Page?action=_revision&page=2, the link is only org/repo/wiki/Page?page=2, thus bringing the user back to the wiki page.

It looks like $paginationParams is not correctly set in the base/paginate template in this specific case, I do not know why.

Example: https://demo.gitea.com/na-Itms/test/wiki/Home?action=_revision

Screenshots

image

Gitea Version

1.22.1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox 128
@na-Itms na-Itms added topic/ui Change the appearance of the Gitea UI type/bug labels Aug 1, 2024
@lunny lunny mentioned this issue Aug 1, 2024
Merged
@lunny lunny added this to the 1.22.2 milestone Aug 1, 2024
@lafriks lafriks closed this as completed in 976f78e Aug 3, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Aug 3, 2024
@lunny @GiteaBot
Fix wiki revision pagination (go-gitea#31760)
4f68b75 
Fix go-gitea#31755
@GiteaBot GiteaBot mentioned this issue Aug 3, 2024
Merged
wolfogre pushed a commit that referenced this issue Aug 4, 2024
@GiteaBot @lunny
Fix wiki revision pagination (#31760) (#31772)
82003a3 
Backport #31760 by @lunny

Fix #31755

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.2
Development

Successfully merging a pull request may close this issue.

Fix wiki revision pagination lunny/gitea
2 participants
@lunny @na-Itms