Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing commits with different email capitalization #2661

Closed
CaeruleusAqua opened this issue Oct 5, 2017 · 1 comment · Fixed by #2663
Closed

Signing commits with different email capitalization #2661

CaeruleusAqua opened this issue Oct 5, 2017 · 1 comment · Fixed by #2663
Labels
type/bug
Milestone
1.3.0

Comments

@CaeruleusAqua
Copy link
Contributor

Gitea seems to have problems signing commits if the capitalization of the email address of the git user and the key does not match! On my local machine with "git verify-commit" the signature is verified correctly.

git verify-commit dc5fb4a4e5cf839cd30d11e8077bee7e7eecdcc3
gpg: Signature made Wed 04 Oct 2017 06:59:48 PM CEST
gpg: using RSA key 3FC8FB4B947F9057
gpg: Good signature from "Julian Scholle <julian.scholle -at- iff - fraunhofer - de>" [ultimate]

image

image

  • Gitea version (or commit ref): 4325320
@lafriks lafriks added this to the 1.x.x milestone Oct 5, 2017
@sapk
Copy link
Member

sapk commented Oct 5, 2017

This should be easy to fix.
I haven't time rigth now. Just for information the change need to be done here : https://github.com/go-gitea/gitea/blob/master/models/gpg_key.go#L405 and sorround everythings with strings.ToLower(email)

CaeruleusAqua added a commit to CaeruleusAqua/gitea that referenced this issue Oct 5, 2017
@CaeruleusAqua
GPG key email verification no longer case sensitive (go-gitea#2661)
5e2210c 
Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
@CaeruleusAqua CaeruleusAqua mentioned this issue Oct 5, 2017
Merged
@lafriks lafriks modified the milestones: 1.x.x, 1.3.0 Oct 5, 2017
CaeruleusAqua added a commit to CaeruleusAqua/gitea that referenced this issue Oct 6, 2017
@CaeruleusAqua
case insensitive GPG key email verification now cached (go-gitea#2661)
57d9397 
Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
lafriks pushed a commit that referenced this issue Oct 6, 2017
@CaeruleusAqua @lafriks
GPG key email verification no longer case sensitive (#2661) (#2663)
92123fe 
* GPG key email verification no longer case sensitive (#2661)

* case insensitive GPG key email verification now cached (#2661)

Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
sapk pushed a commit to sapk-fork/gitea that referenced this issue Oct 26, 2017
@CaeruleusAqua @sapk
GPG key email verification no longer case sensitive (go-gitea#2661) (g…
0c22cb7 
…o-gitea#2663)

* GPG key email verification no longer case sensitive (go-gitea#2661)

* case insensitive GPG key email verification now cached (go-gitea#2661)

Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
lunny pushed a commit that referenced this issue Oct 27, 2017
@sapk @lunny
Backport to v1.2 of PR 2266 2467 2663 (#2788)
357d5a5 
* Only check at least one email gpg key (#2266)

* Only require one email (possibly not yet validated)

* Update message error and check validation of commit

* Add integrations tests

* Complete integration for import

* Add pre-check/optimization

* Add some test (not finished)

* Finish

* Fix fixtures

* Fix typo

* Don't guess key ID

* Make repo private to no interfere with other tests (#2467)

* GPG key email verification no longer case sensitive (#2661) (#2663)

* GPG key email verification no longer case sensitive (#2661)

* case insensitive GPG key email verification now cached (#2661)

Signed-off-by: Julian Scholle <julian.scholle@googlemail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

GPG key email verification no longer case sensitive (#2661) CaeruleusAqua/gitea
3 participants
@lafriks @CaeruleusAqua @sapk