Workflow with on.push.paths triggers only on second push

[nblock]

Description

The following workflow configuration file should trigger on push events to any branch where files anywhere below dir2/ got changed.

---
name: Run only on changes within dir2

on:
  push:
    paths:
      - dir2/**

jobs:
  dir2:
    runs-on: playground
    steps:
      - name: Step for files in dir2
        run: |
          echo 'something changed'

With Gitea 1.20.2 and act runner 0.2.4 this works when pushing a commit that modifies files in dir2/ and the branch already exists on the remote (e.g. the branch main).

It does not work when a new commit that modifies files in dir2/ is pushed to a new branch on the remote. The event is silently ignored. However, the workflow triggers when pushing a second commit to the same branch.

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

git version 2.39.2

Operating System

Debian 12

How are you running Gitea?

Official release supervised by systemd.

Database

PostgreSQL

[CaiCandong]

I was able to reproduce your problem and I'm trying to locate the bug.

[CaiCandong]

I found out why this problem occurs, when you push a new branch, OldCommitID is a null value.

Where the error occurred:

gitea/modules/actions/workflows.go

Lines 256 to 260 in 54c28fd

	}
	case "paths":
	filesChanged, err := commit.GetFilesChangedSinceCommit(pushPayload.Before)
	if err != nil {
	log.Error("GetFilesChangedSinceCommit [commit_sha1: %s]: %v", commit.ID.String(), err)

It seems that OldCommitID for new branches is a null value that seems to be designed.

gitea/services/repository/push.go

Lines 132 to 148 in 54c28fd

	} else { // is new tag
	newCommit, err := gitRepo.GetCommit(opts.NewCommitID)
	if err != nil {
	return fmt.Errorf("gitRepo.GetCommit(%s) in %s/%s[%d]: %w", opts.NewCommitID, repo.OwnerName, repo.Name, repo.ID, err)
	}
	commits := repo_module.NewPushCommits()
	commits.HeadCommit = repo_module.CommitToPushCommit(newCommit)
	commits.CompareURL = repo.ComposeCompareURL(git.EmptySHA, opts.NewCommitID)
	notification.NotifyPushCommits(
	ctx, pusher, repo,
	&repo_module.PushUpdateOptions{
	RefFullName: opts.RefFullName,
	OldCommitID: git.EmptySHA,
	NewCommitID: opts.NewCommitID,
	}, commits)