Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 Response after successfully applying patch from diff file #22621

Closed
pahofmann opened this issue Jan 27, 2023 · 3 comments · Fixed by #23056 or #23086
Closed

404 Response after successfully applying patch from diff file #22621

pahofmann opened this issue Jan 27, 2023 · 3 comments · Fixed by #23056 or #23086
Labels
type/bug
Milestone
1.19.0

Comments

@pahofmann
Copy link

pahofmann commented Jan 27, 2023 •
edited
Loading

Description

When applying a patch (via code tab -> Add File -> Apply Patch) the patch is applied correctly, but the server responds with a 404. The after creating the patch commit the redirect that 404s is for USER/REPOSITORY/branch/main/diff.patch, which does not exist of course.

I could reproduce it here:
https://try.gitea.io/pahofmann/patch-404-test/
After I applied the patch I was redirected to https://try.gitea.io/pahofmann/patch-404-test/src/branch/main/diff.patch

Gitea Version

1.18.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://gist.github.com/pahofmann/fb2c2e9daa8ff8d2c846b85e1eca3598

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Fresh setup in container.

Database

SQLite
@yp05327
Copy link
Contributor

yp05327 commented Feb 22, 2023 •
edited
Loading

I reproduced this bug and got incorrect commits count in the latest version.
image

Edit: If you restart the server, it will be correct again.

Issue here

@yp05327
Copy link
Contributor

yp05327 commented Feb 22, 2023

And the default commit name in form is Update '', but the real commit name will be Apply Patch
image

This was referenced Feb 22, 2023
Merged
Closed
Merged
@lunny lunny added this to the 1.19.0 milestone Feb 23, 2023
jolheiser pushed a commit that referenced this issue Feb 23, 2023
@yp05327
Fix commit name in Apply Patch page (#23086)
ed954b0 
Fixes
#22621 (comment)
@yardenshoham yardenshoham mentioned this issue Feb 23, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 23, 2023
@yp05327 @yardenshoham
Fix commit name in Apply Patch page (go-gitea#23086)
33b0c1b 
Fixes
go-gitea#22621 (comment)
lunny pushed a commit that referenced this issue Feb 24, 2023
@yardenshoham @yp05327
Fix commit name in Apply Patch page (#23086) (#23099)
b4ed3f0 
Backport #23086

Fixes
#22621 (comment)

Co-authored-by: yp05327 <576951401@qq.com>
@yp05327
Copy link
Contributor

yp05327 commented Feb 24, 2023

I don't think this issue can be closed, as the main fix PR is #23056 which is not closed.

zeripath pushed a commit that referenced this issue Feb 24, 2023
@yp05327
Redirect to the commit page after applying patch (#23056)
9eb61b7 
Fixes #22621
@yardenshoham yardenshoham mentioned this issue Feb 24, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 24, 2023
@yp05327 @yardenshoham
Redirect to the commit page after applying patch (go-gitea#23056)
20c0203 
Fixes go-gitea#22621
zeripath pushed a commit to zeripath/gitea that referenced this issue Feb 24, 2023
@yp05327 @zeripath
Redirect to the commit page after applying patch (go-gitea#23056) & F…
dd7efac 
…ix commit name in Apply Patch page (go-gitea#23086)

Backport go-gitea#23056
Backport go-gitea#23086

Fixes go-gitea#22621

Fixes
go-gitea#22621 (comment)
@zeripath zeripath mentioned this issue Feb 24, 2023
Merged
techknowlogick pushed a commit that referenced this issue Feb 25, 2023
@yardenshoham @yp05327
Redirect to the commit page after applying patch (#23056) (#23127)
28625fb 
Backport #23056

Fixes #22621

Co-authored-by: yp05327 <576951401@qq.com>
lunny pushed a commit that referenced this issue Mar 15, 2023
@zeripath @yp05327
Redirect to the commit page after applying patch (#23056) & Fix commi…
9107a87 
…t name in Apply Patch page (#23086) (#23131)

Backport #23056
Backport #23086

Fixes #22621

Fixes
#22621 (comment)

Co-authored-by: yp05327 <576951401@qq.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.19.0
3 participants
@lunny @pahofmann @yp05327