Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member of Two Teams Shows Up Twice on Review Request #18808

Closed
stu1811 opened this issue Feb 18, 2022 · 0 comments · Fixed by #26784
Closed

Member of Two Teams Shows Up Twice on Review Request #18808

stu1811 opened this issue Feb 18, 2022 · 0 comments · Fixed by #26784
Labels
type/bug
Milestone
1.20.4

Comments

@stu1811
Copy link

stu1811 commented Feb 18, 2022

Gitea Version

1.16

Git Version

2.24.1

Operating System

RHEL 7

How are you running Gitea?

I was able to reproduce this on try.gitea.io. https://try.gitea.io/developers/foobar/pulls/1

We download the binary (linux-amd64) from the releases page and install in /usr/bin.

Database

MySQL

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Create two teams with at least one user on both teams. Create a pull request and add both teams as reviewers. Login as the user on both teams and go to your "Review Requested ". The PR will appear twice in the list.

Screenshots

image
@lunny lunny added the type/bug label Feb 22, 2022
@lng2020 lng2020 mentioned this issue Aug 29, 2023
Merged
@lunny lunny added this to the 1.20.4 milestone Aug 29, 2023
lunny pushed a commit that referenced this issue Sep 3, 2023
@lng2020
Fix wrong review requested number (#26784)
f1fe102 
Fix the wrong review requested number mentioned by #18808 .
Fix #18808 
Before:

![ksnip_20230829-140750](https://github.com/go-gitea/gitea/assets/70063547/0af2055b-6f16-4699-a944-c7186831d7f9)
After:

![ksnip_20230829-141817](https://github.com/go-gitea/gitea/assets/70063547/16633264-20ba-45e3-bfbb-a495ed76a45b)
@GiteaBot GiteaBot mentioned this issue Sep 3, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 3, 2023
@lng2020 @GiteaBot
Fix wrong review requested number (go-gitea#26784)
9982596 
Fix the wrong review requested number mentioned by go-gitea#18808 .
Fix go-gitea#18808 
Before:

![ksnip_20230829-140750](https://github.com/go-gitea/gitea/assets/70063547/0af2055b-6f16-4699-a944-c7186831d7f9)
After:

![ksnip_20230829-141817](https://github.com/go-gitea/gitea/assets/70063547/16633264-20ba-45e3-bfbb-a495ed76a45b)
KN4CK3R pushed a commit that referenced this issue Sep 3, 2023
@GiteaBot @lng2020
Fix wrong review requested number (#26784) (#26880)
2a18479 
Backport #26784 by @lng2020

Fix the wrong review requested number mentioned by #18808 .
Fix #18808 
Before:

![ksnip_20230829-140750](https://github.com/go-gitea/gitea/assets/70063547/0af2055b-6f16-4699-a944-c7186831d7f9)
After:

![ksnip_20230829-141817](https://github.com/go-gitea/gitea/assets/70063547/16633264-20ba-45e3-bfbb-a495ed76a45b)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.4
Development

Successfully merging a pull request may close this issue.

Fix wrong review requested number lng2020/gitea
2 participants
@lunny @stu1811