Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation wrong for word color in PR #16647 #17384

Closed
infl00p opened this issue Oct 21, 2021 · 0 comments · Fixed by #17390
Closed

Translation wrong for word color in PR #16647 #17384

infl00p opened this issue Oct 21, 2021 · 0 comments · Fixed by #17390

Comments

@infl00p
Copy link

infl00p commented Oct 21, 2021

Gitea Version

ecfac78

Git Version

2.20

Operating System

No response

How are you running Gitea?

N/A

Database

No response

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

PR #16647 changes dedicated translation strings for the word "color", to a single generic key "color".
But color is a word that can be a verb, adjective or a noun and these changes are incompatible with many languages.
In commit_graph.color the word "Color" is an adjective, in the other 2 it's a noun. I propose to revert this, or if a generic key is needed it must distinguish all possible grammar of the word (verb, noun, adjective, plural, single).

Regards

Screenshots

No response

zeripath added a commit to zeripath/gitea that referenced this issue Oct 21, 2021
Fix go-gitea#17384

Signed-off-by: Andrew Thornton <art27@cantab.net>
6543 pushed a commit that referenced this issue Oct 21, 2021
Fix #17384

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
Fix go-gitea#17384

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant