Skip to content

Commit

Permalink
Log STDERR of external renderer when it fails (#22442) (#22444)
Browse files Browse the repository at this point in the history
Backport #22442.
  • Loading branch information
jtran committed Jan 14, 2023
1 parent 265d438 commit 7b60d47
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion modules/markup/external/external.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package external

import (
"bytes"
"fmt"
"io"
"os"
Expand Down Expand Up @@ -133,11 +134,13 @@ func (p *Renderer) Render(ctx *markup.RenderContext, input io.Reader, output io.
if !p.IsInputFile {
cmd.Stdin = input
}
var stderr bytes.Buffer
cmd.Stdout = output
cmd.Stderr = &stderr
process.SetSysProcAttribute(cmd)

if err := cmd.Run(); err != nil {
return fmt.Errorf("%s render run command %s %v failed: %w", p.Name(), commands[0], args, err)
return fmt.Errorf("%s render run command %s %v failed: %w\nStderr: %s", p.Name(), commands[0], args, err, stderr.String())
}
return nil
}

0 comments on commit 7b60d47

Please sign in to comment.