Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #92

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Clean up #92

merged 4 commits into from
Dec 17, 2020

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

  • adds a makefile to enable easy fmt checks, lint, vet, test -race
  • removes the deprecated StartImmediately() func
  • runs go test -race and cleans up all the race conditions

Which issue(s) does this PR fix/relate to?

resolves #75

List any changes that modify/break current functionality

Have you included tests for your changes?

👍

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler self-assigned this Dec 17, 2020
arjunmahishi
arjunmahishi previously approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@arjunmahishi arjunmahishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 🎉
Awesome PR!

.github/workflows/go_test.yml Outdated Show resolved Hide resolved
Streppel
Streppel approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@Streppel Streppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool @JohnRoesler!

@JohnRoesler JohnRoesler merged commit caab14a into go-co-op:master Dec 17, 2020
@JohnRoesler JohnRoesler deleted the clean-up branch December 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Streppel Streppel Streppel approved these changes

@arjunmahishi arjunmahishi arjunmahishi approved these changes

Assignees

@JohnRoesler JohnRoesler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate other possible race conditions
3 participants
@JohnRoesler @Streppel @arjunmahishi