feat(remove/job): remove a particular job reference from the schedule…

[dlaweb]

…r after the last execution of the job

What does this do?

With the scheduler we have the possibility to run a Job only once but when the Job has finished its execution we still have a reference in the Scheduler while it will not be used anymore this can lead to keep obsoletes scheduler Jobs references.

This PR allow the user to add a flag RemoveAfterLastExec in order to remove the job after the last job execution.

Which issue(s) does this PR fix/relate to?

resolves #85

List any changes that modify/break current functionality

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

• Updated example_test.go
• Updated README.md

Notes

[JohnRoesler]

Thanks for the feature PR!

please add a test to the example_test.go file so that it appears in the go docs

[JohnRoesler]

Thank you!

[apremalal]

Hi, Thanks for adding this feature. Is it possible to create a release tag with this change?

[JohnRoesler]

@apremalal yes we are working on a release soon. This feature may change slightly before the release, but the functionality will be available.

[JohnRoesler]

@Streppel you had mentioned why not just remove after the run limit is reached. I think having this available as is with a specific flag is valuable, because a user may not be default want to remove the job. For example, start a job with a limit of 1 run, then later edit the run limit to 2, and then later 3, etc. With this flag, we allow specifically asking to remove the job after the limit is reached.

[Streppel]

@JohnRoesler I see... Let's keep it that way, then; I think this makes sense. Even though, creating a new job would be a simpler way of achieving the same result, right?