Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after job listener #734

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

manuelarte
Copy link
Contributor

What does this do?

Adding an after locker error listener

Which issue(s) does this PR fix/relate to?

It adds the possibility to react when the locker returns an error.

List any changes that modify/break current functionality

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler
Copy link
Contributor

@manuelarte could you run @golangci-lint run --fix? Linting is complaining

@manuelarte
Copy link
Contributor Author

@manuelarte could you run @golangci-lint run --fix? Linting is complaining

Done (I see more lint issues, unused-parameter, but I did not fix them)

@JohnRoesler JohnRoesler merged commit 8949701 into go-co-op:v2 Jun 19, 2024
4 checks passed
@manuelarte manuelarte deleted the adding-after-lock-error-listener branch June 21, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants