Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Job method called 'LimitRunsTo' #67

Merged

Conversation

arjunmahishi
Copy link
Member

What does this do?

Exposes a new Job method called LimitRunsTo to control how many times a job should run

Which issue(s) does this PR fix/relate to?

Closes #24

List any changes that modify/break current functionality

Backward compatible

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Please suggest better function/struct/field names if required.

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arjunmahishi
Copy link
Member Author

Ok. Thanks for the review @JohnRoesler @dustin-decker @Streppel
Merging it now.

@arjunmahishi arjunmahishi merged commit daf5304 into go-co-op:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Run a job once
4 participants