Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for executing jobs every Month/Months #47

Merged
merged 2 commits into from
Jul 19, 2020

Conversation

arjunmahishi
Copy link
Member

What does this do?

Add support for executing jobs every Month/Months

Which issue(s) does this PR fix/relate to?

#43

List any changes that modify/break current functionality

Doesn't break any current functionality

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

@arjunmahishi arjunmahishi changed the title Feature/add month support Add support for executing jobs every Month/Months Jul 18, 2020
@@ -54,6 +54,8 @@ func main() {
s2.Every(2).Days().Do(task)
s2.Every(1).Week().Do(task)
s2.Every(2).Weeks().Do(task)
s2.Every(1).Month(time.Now().Day()).Do(task)
s2.Every(2).Months(15).Do(task)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should support At() for the month - otherwise I assume it runs at midnight by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes by default it runs at 00:00:00. And It does support At()

@arjunmahishi arjunmahishi linked an issue Jul 18, 2020 that may be closed by this pull request
Copy link
Member

@Streppel Streppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRoesler JohnRoesler merged commit 5832008 into go-co-op:master Jul 19, 2020
@arjunmahishi arjunmahishi deleted the feature/add-month-support branch July 19, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Monthly Schedule
3 participants