fixes 38 #39
Merged
fixes 38 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streppel
requested review from
JohnRoesler and
arjunmahishi
and removed request for
JohnRoesler
| return | ||
| } | ||
| } | ||
| }() | ||
|
|
||
| return stopped | ||
| return s.stopChan |
There was a problem hiding this comment.
(Unrated to this PR) Do we really need to expose this chan to the user? We already have a s.Stop() that takes care of stopping the scheduler.
There was a problem hiding this comment.
You're absolutely right, but as this would be a breaking change I decided to leave it for another PR
arjunmahishi
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38