-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in scheduler, rescheduling jobs immediately #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the seconds issue that I've left in there @JohnRoesler, other than that it looks good
If you all could pull this down and do some testing as well - that would be great. I ran it multiple times last night for ~10 minutes a time. Want to make sure this isn't breaking something else unintentionally. Another reason for us to make some better tests using mocked time 😁 |
Doing it right now :)! Also I'll make some commits in this branch if you're ok with it |
@Streppel go for it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Streppel your changes look good - if you're good with it, then let's merge this!
@arjunmahishi any closing thoughts before we merge? |
Nope. |
Output:
Closes #20