Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for cron expressions #150

Merged
merged 1 commit into from
Apr 6, 2021
Merged

add support for cron expressions #150

merged 1 commit into from
Apr 6, 2021

Conversation

JohnRoesler
Copy link
Contributor

@JohnRoesler JohnRoesler commented Apr 3, 2021 •
edited
Loading

What does this do?

  • imports robfig's cron to handle parsing cron expressions
  • tests for cron expressions and error cases when the wrong functions are chained together

Which issue(s) does this PR fix/relate to?

#28

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

arjunmahishi
arjunmahishi approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@arjunmahishi arjunmahishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🎉

@JohnRoesler JohnRoesler merged commit b6cac80 into go-co-op:master Apr 6, 2021
@JohnRoesler JohnRoesler deleted the cron-expression branch April 6, 2021 20:21
@renovate renovate bot mentioned this pull request May 22, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunmahishi arjunmahishi arjunmahishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnRoesler @arjunmahishi