Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bunch of things #137

Merged
merged 5 commits into from
Mar 8, 2021
Merged

a bunch of things #137

merged 5 commits into from
Mar 8, 2021

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

  • renamed job.Err to job. Error
  • remove, removeAfterLastRun - just remove when a job hits the limit by default. we don't have any way to restart a job, so there is not point in keeping them in the scheduler once they're stopped
  • add milliseconds explicitly as a unit (already available using the Every(time.Duration) option)
  • allow At() to accept an interface, string or time.Time (parsing hours down if time.Time)

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

Streppel
Streppel previously approved these changes Mar 8, 2021
Streppel
Streppel previously approved these changes Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants