Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition #124

Merged
merged 1 commit into from
Feb 21, 2021
Merged

fix race condition #124

merged 1 commit into from
Feb 21, 2021

Conversation

amirhosseinvz94
Copy link

What does this do?

jobs() method lock the jobs to get list of them but after we call Jobs(),this method lock jobs until get list of them, but after this method finished, the caller of this method should need lock the jobs because maybe it need to check current state and no past state, and if in this state removebytag() remove any job this may generate race condition (because used append() function on job in removebytag())

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants