Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with StartAt() in v0.5.0 #103

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Conversation

JohnRoesler
Copy link
Contributor

@JohnRoesler JohnRoesler commented Jan 15, 2021

What does this do?

  • fixes a bug we introduced in v0.5.0
  • introduced startAtTime field on the job struct so we know when a job is scheduled to start at a specific time and we should go ahead and start the timer!

Which issue(s) does this PR fix/relate to?

#102 #98

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

scheduler.go Outdated Show resolved Hide resolved
@JohnRoesler JohnRoesler merged commit e0835f6 into go-co-op:master Jan 15, 2021
@JohnRoesler JohnRoesler deleted the fix-v0.5.0 branch January 15, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants