Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

2604 - Override cow token image in activities modal #2606

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

W3stside
Copy link
Contributor

Summary

Fixes #2604

There currently isn't cow token image on the uni repo: https://github.com/Uniswap/assets/master/blockchains/ethereum/assets/0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab/logo.png

Also check the TODO in the changes but why is the vCow and Cow token logos the same? we have vCowLogo in the assets folder

@W3stside W3stside requested review from a team March 29, 2022 11:09
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

@W3stside , great!
I can see COW token image in the activity modal now.
Besides, as you have mentioned above, vCOW and COW tokens have the same image
vcow-cow

The only issue I can add here, is that Cow Protocol token's list does not have image in this PR (but has in Prod)
cow

@W3stside
Copy link
Contributor Author

@elena-zh not sure why prod shows it but not local seeing as the list doesn't have a logoURI at all in it. @anxolin any ideas? is there some caching happening in local and the actual list is updated?

@W3stside
Copy link
Contributor Author

merging, but let's get some eyes on #2606 (comment) and possible implications of 70028dd

@W3stside W3stside merged commit 9fd4761 into hotfix/1.12.3 Mar 29, 2022
@W3stside W3stside mentioned this pull request Mar 29, 2022
W3stside added a commit that referenced this pull request Mar 29, 2022
* override cow token image

* use vCowLogo
@W3stside W3stside mentioned this pull request Mar 29, 2022
@elena-zh
Copy link

@elena-zh not sure why prod shows it but not local seeing as the list doesn't have a logoURI at all in it. @anxolin any ideas? is there some caching happening in local and the actual list is updated?

@W3stside , I realized that the Prod starts showing the icon after I open the list https://tokenlists.org/token-list?url=token-list.cow.eth
image
Before this action, I also see a broken icon there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants