Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fee subsidy modal styles #2585

Merged
merged 13 commits into from
Mar 25, 2022
Merged

Fee subsidy modal styles #2585

merged 13 commits into from
Mar 25, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Mar 24, 2022

Summary

Current

Screen Shot 2022-03-24 at 16 33 39

New

Screen.Recording.2022-03-24.at.16.09.57.mov

New: Mobile

Screen Shot 2022-03-24 at 16 17 54

New: Desktop => Light Mode

Screen Shot 2022-03-24 at 16 42 45

@fairlighteth fairlighteth requested review from a team March 24, 2022 16:43
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @fairlighteth , great changes!

Some minor issues:

  1. The table has square boarders in iOS 15.3
    image
    image

  2. Might be considered as a nitpick, but it seems that the highlighting exceeds the boarders of the table. Is it done intentionally?
    image

@elena-zh
Copy link

  1. Also, when highlighted, there is no boarder between columns
    image

@elena-zh
Copy link

elena-zh commented Mar 25, 2022

I noticed that the modal is displayed at the bottom of the screen in iPad mini with iOS 15.3.1 in Safari browser in the portrait mode
image

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fairlighteth , changes LGTM now.
Thank you!

@fairlighteth fairlighteth merged commit 66dcd50 into release/1.12.0 Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants