Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Show real vCow and Cow data on profile page #2568

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Show real vCow and Cow data on profile page #2568

merged 6 commits into from
Mar 23, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Mar 21, 2022 •
edited
Loading

Summary

  • gets the real vCow and Cow data and shows it in the Profile page
  • changes repo branch and vCow and Cow Rinkeby address

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @nenadV91 , great changes!
I can see actual claimed balance for different accounts.
Some notes:

  1. Based on the discussion in the Profile page: Add vCOW swap feature cards #2564 (comment), we should show card with 0 COW balance + banner when a user is not connected
  2. The same is when a user has 0 COW in the wallet

However, I'm not sure if this is related to the current task..

anxolin
anxolin suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nenadV91 this PR is not easy to review. you add logic for load the balance, but at the same incorporate so many unrelated changes

Please, each PR does only one thing that makes it easy to review. Otherwise we will miss errors.

Also, why do we need to review the changes from @fairlighteth again?

fairlighteth and others added 2 commits March 22, 2022 14:22
@fairlighteth
Profile page: Add vCOW swap feature cards (#2564)
baf2293 
* Style vCOW swap cards.

* Style vCOW swap cards. (#2565)

* Add governance card banner. (#2566)

* Add governance card banner.

* Governance banner update styles.

* Make question icon use dynamic dark/light mode colors.

* Center content properly cross devices.

* Dummy values.

* Disable unused vars

* Cleanup obsolete color
@nenadV91
Connect UI and vCow data
8ba4c0c
@nenadV91
Copy link
Contributor Author

@anxolin Updated this was created before @fairlighteth merged his PR and that is why it was just a draft, but its fixed now.

@nenadV91 nenadV91 marked this pull request as ready for review March 22, 2022 17:46
@nenadV91 nenadV91 requested a review from anxolin March 22, 2022 17:46
@W3stside
Copy link
Contributor

please point to #2573

@W3stside W3stside added the RELEASE Included in the release that is being closed label Mar 22, 2022
@nenadV91
Copy link
Contributor Author

@W3stside Is the latest @fairlighteth PR with the swap UI cards merged into release branch?

@nenadV91 nenadV91 changed the base branch from develop to release/1.12.0 March 22, 2022 19:46
@nenadV91 nenadV91 changed the base branch from release/1.12.0 to develop March 22, 2022 19:46
@W3stside
Copy link
Contributor

Why ar you pointing back at develop?

@nenadV91
Copy link
Contributor Author

Because its easier to review and if I change to release, changed files will also include the ones from this PR #2564 since that PR is not in the release branch.

anxolin
anxolin approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nenadV91 nenadV91 changed the base branch from develop to release/1.12.0 March 23, 2022 10:00
@nenadV91 nenadV91 merged commit 1e02a05 into release/1.12.0 Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside left review comments

@anxolin anxolin anxolin approved these changes

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nenadV91 @elena-zh @W3stside @anxolin @fairlighteth