Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix for already claimed button on claim successful screen #2478

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

nenadV91
Copy link
Contributor

Summary

Fixes #2416

Fixes the issue mentioned in the ticked
Couldn't test this properly because couldn't find working Rinkeby addresses.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2022

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Leandro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Feb 21, 2022

The changes LGTM!
However, I have found another edge case: sometimes, when I try to cancel a transaction, I can face race conditions, so I can get a 'pending forever' transaction (reported in #1832)
So when Claim transaction runs into this state, I can see 'Already claimed' button on the Pending screen
Screenshot_9

However, I'm not sure whether we need to spend a lot of time in order to fix this..
@nenadV91 , @alfetopito , WDYT?

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just retested: the issue I have described is reproducible in this PR

@elena-zh elena-zh self-requested a review February 21, 2022 16:28
@elena-zh
Copy link

Btw, I was not able to reproduce the issue while testing #2485 PR.

@nenadV91
Copy link
Contributor Author

@elena-zh I will merge this since I can't reproduce that, if it still happens we can will fix it in another PR.

…dy-claimed-button-fix"

This reverts commit c84734c, reversing
changes made to a6a8995.
@nenadV91 nenadV91 merged commit 6be36ca into develop Feb 24, 2022
@nenadV91 nenadV91 deleted the 2416/already-claimed-button-fix branch February 24, 2022 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Already claimed' button appears on the Claim successful screen
3 participants