Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Hotfix/1.10.1 - Enable claiming in prod #2395

Merged
merged 14 commits into from
Feb 11, 2022
Merged

Hotfix/1.10.1 - Enable claiming in prod #2395

merged 14 commits into from
Feb 11, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Feb 7, 2022

Summary

  • Enable claiming in prod
  • Cherry-pick some commits from develop

Changelog

git log --oneline origin/hotfix/1.10.1...origin/master --no-decorate

60cfffe 2382/already claimed (#2394)
1ab7b5b Removed Ethereum word from popup text msg (#2412)
c7ba6d4 Show claimed context when already claimed (#2410)
56311fb Update vcow blog links based on chain id (#2408)
66ed3cb Show banner if the user has claimed already (#2393)
d65d7f0 Get deployment time per network (#2407)
8e3ae44 Update contract
c770626 Updated gas estimation for gchain (#2391)
0e0ebae Improve responsiveness of header elements. (#2376)
72d923e Add alternative claim success sound. (#2384)
0cab018 remove unused audio. (#2348)
5586fe9 Fix token display in dark/light mode for transactions. (#2386)
6e9d521 Enable claiming on prod and ens

Todo

  • Change smart contract address for vCOW: Both for Gnosis Chain and mainnnet
  • Blog post link

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

* Using hardcoded gas values for gchain

* Using Blockscout's gas oracle on gchain instead of hardcoded values

* Adding 20% extra margin for gas estimation

* Sorting the imports a little bit

Co-authored-by: Leandro <leandro.boscariol@gnosis.io>
@nenadV91 nenadV91 marked this pull request as ready for review February 7, 2022 15:03
@nenadV91 nenadV91 requested review from a team February 7, 2022 15:09
@elena-zh
Copy link

elena-zh commented Feb 7, 2022

I retested changes for

And these changes LGTM there.
I can't retest changes for 'Enable claiming on prod and ens' as it will be visible to me in Prod env-t only.
In order to test this feature Updated gas estimation for gchain as well as regression tests on other claims, I need a new contract updated.

@anxolin
Copy link
Contributor

anxolin commented Feb 7, 2022

I can't retest changes for 'Enable claiming on prod and ens' as it will be visible to me in Prod env-t only.
In order to test this feature Updated gas estimation for gchain as well as regression tests on other claims, I need a new contract updated.

Should be updated now

@elena-zh elena-zh mentioned this pull request Feb 8, 2022
@elena-zh
Copy link

elena-zh commented Feb 8, 2022

Weird things are happening in this PR: I stop seeing investment options for an account when I switch to another network, then return back.
See the video: https://watch.screencastify.com/v/AyFi3IDgzEM1hFckds9c

* Get deployment time per network

* Set cache
@elena-zh
Copy link

elena-zh commented Feb 8, 2022

Weird things are happening in this PR: I stop seeing investment options for an account when I switch to another network, then return back. See the video: https://watch.screencastify.com/v/AyFi3IDgzEM1hFckds9c

Fixed now.

Also, I was not able to run tests for Updated gas estimation for gchain as GC deployment data was not updated, so I'm able to see only Rinkeby investment claims in this PR.

All the rest changes LGTM.

nenadV91 and others added 5 commits February 9, 2022 12:32
* Show banner if the user has claimed already

* Update claimed banner message and color

* Change one const name
* Update vcow blog links based on chain id

* Updated the blog root link const name

* Updated the links hook name and const
* Showing claimed vCOW balance amount in summary when already claimed

* Updating body message when user already claimed

* Update button text when already claimed

* Added isClaimed to `ClaimCommonTypes`

* Show network name on already claimed banner

* Do not show inner body msg when already claimed

* Show connect button on already claimed if disconnected

* Fix `@src` import

Co-authored-by: Leandro <leandro.boscariol@gnosis.io>
* Updated state to store count of classified claims other than a boolean

* Updated the updater to store the count of classified claims

* Updated claims on other network banner to check according to claim counts

* Fixed issues with claim on multiple networks

- Updated state to add new dimension to claim info: account
  Otherwise when checking a different account the state would be
  preserved and would lead to bad data
- Refactored Updater to fix dependency on obj causing it to
  being stuck in a re-render loop
- Fixed logic that compared different types using `===` instead of `==`
- Fixed logic that was causing claim to be displayed when there were no claims

* Refactoring variable

Co-authored-by: Leandro <leandro.boscariol@gnosis.io>
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

Needed for the release:

  1. vCOW contract address for all networks
  2. Double check blog posts are correct

@anxolin
Copy link
Contributor

anxolin commented Feb 11, 2022

Awesome! Big day tomorrow 🎉

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I have found a new UI issue in the PR #2415, but it might be addresses later.

* Use gip-13 data

* Update contract addresses
@anxolin anxolin merged commit 3ebb36a into master Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants