This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Fix e2e #2379
Merged
Fix e2e #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alfetopito
approved these changes
Feb 2, 2022
Closed
nenadV91
approved these changes
Feb 3, 2022
|
Would be great to have this already, so I'm making it ready and merging it |
|
Perfect! also, do you think you can revert the other PR? #2342 |
It's already closed. |
|
Ahh, somehow i thought it was merged. NVM! all good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try this fix e2e issue by applying the hack described in ethers-io/ethers.js#1683 (thread pointed out by @alfetopito )
The goal is to undo the #2342 if this PR can solve the issue. The reason is jut to avoid modifying the app behaviour for the CI. Ideally the e2e would be as close as possible as the real thing.
To Test
Check Gituhub Actions if it passes