-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
Looks good. One comment:
|
Hey @nenadV91 , great changes! I have just realized that we have another screen where we check available claims for an account: so we show a message about claims in Ethereum, but we are currently connected to Polygon. In order to avoid this, maybe we could disable 'Check' button when connected to an ansupported network? @biocom , @alfetopito , @anxolin , @W3stside , WDYT? |
I agree this would be good. In addition, we could reflect the same error in the primary button (Wrong network). |
💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ideas from Elena and Michel. We can always address as new PR if we don't want to mix (handle unsupported networks)
Hey @nenadV91 , changes LGTM! Just as an enhancement, I'd navigate a user to this screen But anyways, let me know please if I need to create a separate issue for this. Thanks |
@elena-zh Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
* Show add to wallet button * Change message for unsupported network * PR updates * Small PR change * PR update
Summary
Fixes #2297
As defined in the issue:
Adds connect to wallet button on this screen if its not connected
Changes the text if its unsupported network