Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add badges and link to etherscan #2264

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add badges and link to etherscan #2264

merged 2 commits into from
Jan 24, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 23, 2022

Summary

This PR adds the link to etherscan for the claiming and receiving account.

Additionally, adds the logic to show if the receiving account is the connected wallet or not.
Lastly ads a badge to show this and some icons to the show the claiming and receiver account. Please @biocom feel free to remove or style anything here :)

Before:
image

After, claiming for my self:
Screenshot at Jan 23 17-21-44

claiming for someone else:
Screenshot at Jan 23 17-22-19

To Test

  1. Try to claim for yourself and for someone else
  2. Test the links

Background

Optional: Give background information for changes you've made, that might be difficult to explain via comments

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin anxolin requested review from a team January 23, 2022 17:42
@fairlighteth
Copy link
Contributor

Nice this is helpful to further style.

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!
Might be considered as a nitpick, but I'd adjusted labels themselves to make the text inside center-aligned + place labels center-aligned vertically towards the address link.
image

@fairlighteth
Copy link
Contributor

@elena-zh FYI, I will take over styling in a follow up PR. If applicable, will consider your feedback.

@elena-zh
Copy link

Thanks, @biocom !

Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments about path but approved

@anxolin anxolin merged commit 35ba6b3 into develop Jan 24, 2022
maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
* Fix z-index bug which prevented modal click. Center button and remove underline

* Fix code style issues with ESLint

* fix: PR comments

* Fix code style issues with ESLint

* z-index comment

* Fix code style issues with ESLint

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants